build(deps): bump client-go to include pd#10522#67491
Conversation
Signed-off-by: okjiang <819421878@qq.com>
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughUpdated pinned versions of two TiKV dependencies across Go and Bazel manifests. The Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Skipping CI for Draft Pull Request. |
Signed-off-by: okjiang <819421878@qq.com>
|
@okJiang I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details. ⏳ This process typically takes 10-30 minutes depending on the complexity of the changes. ℹ️ Learn more details on Pantheon AI. |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #67491 +/- ##
================================================
- Coverage 77.7878% 77.6260% -0.1618%
================================================
Files 1959 1945 -14
Lines 543377 545063 +1686
================================================
+ Hits 422681 423111 +430
- Misses 119855 121949 +2094
+ Partials 841 3 -838
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
/check-issue-triage-complete |
|
@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, cfzjywxk, lhy1024, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/cherry-pick release-nextgen-202603 |
|
@okJiang: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #67511,
ref tikv/pd#10522, ref tikv/client-go#1935
Problem Summary:
TiDB should consume the merged upstream
client-gochange that includes the RM fallback warning-spam fix fromtikv/pd#10522.What changed and how does it work?
github.com/tikv/client-go/v2tov2.0.8-0.20260401083018-b7f9a9e9d2ab, which is the merged upstream commit fromtikv/client-go#1935github.com/tikv/pd/clientversion atv0.0.0-20260401072359-048f0d8f6f71DEPS.bzlso Bazel fetches the upstreamclient-goartifact instead of the temporary fork artifact used earlier in this PRCheck List
Tests
Manual test steps:
go mod tidymake bazel_preparego test -run TestNonExistent ./br/pkg/... ./lightning/pkg/... ./dumpling/exportgo list ./cmd/tidb-server ./pkg/store/... ./pkg/server/... ./pkg/session/... ./pkg/executor/... ./pkg/planner/... | rg -v '/test/|/tests/|_test$|^github.com/pingcap/tidb/pkg/planner/implementation$' | xargs -n 40 go test -run TestNonExistentSide effects
Documentation
Release note
Summary by CodeRabbit