Skip to content

build(deps): bump client-go to include pd#10522#67491

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
okJiang:codex/bump-client-go-pd10522
Apr 3, 2026
Merged

build(deps): bump client-go to include pd#10522#67491
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
okJiang:codex/bump-client-go-pd10522

Conversation

@okJiang
Copy link
Copy Markdown
Member

@okJiang okJiang commented Apr 1, 2026

What problem does this PR solve?

Issue Number: ref #67511,

ref tikv/pd#10522, ref tikv/client-go#1935

Problem Summary:
TiDB should consume the merged upstream client-go change that includes the RM fallback warning-spam fix from tikv/pd#10522.

What changed and how does it work?

  • bump github.com/tikv/client-go/v2 to v2.0.8-0.20260401083018-b7f9a9e9d2ab, which is the merged upstream commit from tikv/client-go#1935
  • keep the resolved github.com/tikv/pd/client version at v0.0.0-20260401072359-048f0d8f6f71
  • refresh DEPS.bzl so Bazel fetches the upstream client-go artifact instead of the temporary fork artifact used earlier in this PR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • go mod tidy
  • make bazel_prepare
  • go test -run TestNonExistent ./br/pkg/... ./lightning/pkg/... ./dumpling/export
  • go list ./cmd/tidb-server ./pkg/store/... ./pkg/server/... ./pkg/session/... ./pkg/executor/... ./pkg/planner/... | rg -v '/test/|/tests/|_test$|^github.com/pingcap/tidb/pkg/planner/implementation$' | xargs -n 40 go test -run TestNonExistent

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated TiKV client dependencies to latest versions for improved stability.

Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Updated pinned versions of two TiKV dependencies across Go and Bazel manifests. The github.com/tikv/client-go/v2 dependency advanced to commit b7f9a9e9d2ab, and github.com/tikv/pd/client advanced to commit 048f0d8f6f71, with corresponding checksums and mirror URLs refreshed.

Changes

Cohort / File(s) Summary
Dependency Version Updates
DEPS.bzl, go.mod
Updated pinned versions of com_github_tikv_client_go_v2 and com_github_tikv_pd_client with new commit hashes, sha256 checksums, and mirrored download URLs.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly Related PRs

Suggested Labels

ok-to-test, approved, lgtm

Suggested Reviewers

  • lcwangchao
  • YuJuncen
  • xhebox

Poem

🐰 Two hoppy bumps along the way,
TiKV deps get fresh today!
Checksums dance, commits align,
The mirrors gleam in manifest shine!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: bumping the client-go dependency to include a specific upstream fix (pd#10522). It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the required template with Issue Number, Problem Summary, What Changed sections, and a comprehensive Check List including test selection and release notes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2026
@okJiang okJiang changed the title build(deps): test client-go pd#10522 via okJiang fork build(deps): test client-go pd#10522 Apr 1, 2026
Signed-off-by: okjiang <819421878@qq.com>
@okJiang okJiang changed the title build(deps): test client-go pd#10522 build(deps): bump client-go to include pd#10522 fix Apr 1, 2026
@okJiang okJiang changed the title build(deps): bump client-go to include pd#10522 fix build(deps): bump client-go to include pd#10522 Apr 2, 2026
@okJiang okJiang marked this pull request as ready for review April 2, 2026 07:05
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai Bot commented Apr 2, 2026

@okJiang I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details.

⏳ This process typically takes 10-30 minutes depending on the complexity of the changes.

ℹ️ Learn more details on Pantheon AI.

@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 2, 2026

/retest

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.6260%. Comparing base (dcf6f03) to head (e103bfe).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #67491        +/-   ##
================================================
- Coverage   77.7878%   77.6260%   -0.1618%     
================================================
  Files          1959       1945        -14     
  Lines        543377     545063      +1686     
================================================
+ Hits         422681     423111       +430     
- Misses       119855     121949      +2094     
+ Partials        841          3       -838     
Flag Coverage Δ
integration 41.0993% <ø> (+4.9245%) ⬆️
unit 76.8097% <ø> (+0.3693%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 61.5065% <ø> (ø)
parser ∅ <ø> (∅)
br 48.9178% <ø> (-12.0727%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 2, 2026

/retest

@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 2, 2026

/check-issue-triage-complete

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 3, 2026
@ti-chi-bot ti-chi-bot Bot added the approved label Apr 3, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 3, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-03 02:12:39.214425771 +0000 UTC m=+490364.419785818: ☑️ agreed by YuJuncen.
  • 2026-04-03 03:03:29.671611867 +0000 UTC m=+493414.876971924: ☑️ agreed by cfzjywxk.

Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, cfzjywxk, lhy1024, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [YuJuncen,bb7133,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 3, 2026

/retest

1 similar comment
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 3, 2026

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 3dfa425 into pingcap:master Apr 3, 2026
36 of 39 checks passed
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Apr 8, 2026

/cherry-pick release-nextgen-202603

@ti-chi-bot
Copy link
Copy Markdown
Member

@okJiang: new pull request created to branch release-nextgen-202603: #67602.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants