Update lint rules, force testify/assert#699
Merged
Conversation
18 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 101 101
Lines 6831 6831
=======================================
Hits 5367 5367
Misses 1089 1089
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5fe6b5b to
bc9ee54
Compare
ce9a8d5 to
7775f48
Compare
1abb8d3 to
0a07999
Compare
0a07999 to
c9e37f9
Compare
Sean-Der
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update lint rules to forbid the use of direct testing.T helpers. Removed multiple
//nolint:cyclopby consequence of reduced if blocks.Reference issue
pion/.goassets#222