Skip to content

Forbid the use of testing.T helpers#222

Merged
JoTurk merged 1 commit intomasterfrom
impr/test-utils
Apr 23, 2025
Merged

Forbid the use of testing.T helpers#222
JoTurk merged 1 commit intomasterfrom
impr/test-utils

Conversation

@JoTurk
Copy link
Member

@JoTurk JoTurk commented Mar 3, 2025

@Sean-Der
Copy link
Member

Sean-Der commented Mar 4, 2025

@joeturki Lets do it! Want to split the repos, I can do half.

@JoTurk
Copy link
Member Author

JoTurk commented Mar 4, 2025

@Sean-Der I did a bit of work on pion/rtp, and was going to start making PRs tonight, let me start from the start of the list and if you wanna join from the end, and meet in the middle or depends on the pace we can go. what do you think :)

@JoTurk JoTurk force-pushed the impr/test-utils branch 2 times, most recently from 715a323 to cddca30 Compare March 4, 2025 22:33
@JoTurk
Copy link
Member Author

JoTurk commented Mar 4, 2025

@Sean-Der the reason it didn't work is because we exclude forbidigo from test file, I made it so we only exclude it from examples, also we needed analyze-types option.

@JoTurk JoTurk merged commit c5778ca into master Apr 23, 2025
4 checks passed
@JoTurk JoTurk deleted the impr/test-utils branch April 23, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants