Skip to content

Conversation

@kevmo314
Copy link
Contributor

Description

Fixes a small race condition in setSelectedPair that results in an occasional test failure.

=== RUN   TestRoleConflict
=== RUN   TestRoleConflict/Controlling
=== RUN   TestRoleConflict/Controlled
    agent_test.go:2029: 
        	Error Trace:	/home/runner/work/ice/ice/agent_test.go:2029
        	            				/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/asm_amd64.s:1693
        	Error:      	Received unexpected error:
        	            	the agent is closed
        	Test:       	TestRoleConflict/Controlled
--- FAIL: TestRoleConflict (0.81s)
    --- PASS: TestRoleConflict/Controlling (0.20s)
    --- FAIL: TestRoleConflict/Controlled (0.20s)

Reference issue

Fixes #...

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (163dca5) to head (f54523f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   87.45%   87.56%   +0.11%     
==========================================
  Files          43       43              
  Lines        4537     4537              
==========================================
+ Hits         3968     3973       +5     
+ Misses        398      393       -5     
  Partials      171      171              
Flag Coverage Δ
go 87.56% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevmo314 kevmo314 merged commit 649e13a into master Oct 26, 2025
23 of 24 checks passed
@kevmo314 kevmo314 deleted the connected-race branch October 26, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants