Skip to content

Fix race condition in setSelectedPair #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2025
Merged

Fix race condition in setSelectedPair #826

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe7345c
Fix race condition in setSelectedPair
kevmo314 Oct 26, 2025
9754d9f
Update agent.go
kevmo314 Oct 26, 2025
f3f2eb6
Remove unnecessary comments in agent.go
kevmo314 Oct 26, 2025
f54523f
Merge branch 'master' into connected-race
kevmo314 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,13 +504,14 @@ func (a *Agent) setSelectedPair(pair *CandidatePair) {
a.selectedPair.Store(pair)
a.log.Tracef("Set selected candidate pair: %s", pair)

// Signal connected: notify any Connect() calls waiting on onConnected
a.onConnectedOnce.Do(func() { close(a.onConnected) })

// Update connection state to Connected and notify state change handlers
a.updateConnectionState(ConnectionStateConnected)

// Notify when the selected pair changes
// Notify when the selected candidate pair changes
a.selectedCandidatePairNotifier.EnqueueSelectedCandidatePair(pair)

// Signal connected
a.onConnectedOnce.Do(func() { close(a.onConnected) })
}

func (a *Agent) pingAllCandidates() {
Expand Down
Loading