Update lint rules, force testify/assert#192
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 22 22
Lines 2548 2548
=======================================
Hits 1980 1980
Misses 472 472
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RyanPotat
force-pushed
the
RyanPotat/lint/test-helpers
branch
from
9264d6d to
4e77826
Compare
RyanPotat
force-pushed
the
RyanPotat/lint/test-helpers
branch
from
4e77826 to
bb27ec6
Compare
18 tasks
JoTurk
approved these changes
Mar 29, 2025
Member
|
THANK YOU RYAN <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update lint rules to forbid the use of direct testing.T helpers.
Reference issue
pion/.goassets/pull/222