Update lint rules, force testify/assert for tests#220
Merged
Conversation
18 tasks
JoTurk
force-pushed
the
lint/test-helpers
branch
from
8e049ca to
4e0948c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 65.35% 65.28% -0.07%
==========================================
Files 27 27
Lines 2644 2639 -5
==========================================
- Hits 1728 1723 -5
+ Misses 907 906 -1
- Partials 9 10 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
force-pushed
the
lint/test-helpers
branch
2 times, most recently
from
64a6e02 to
389246d
Compare
Use testify's assert package instead of the standard library's testing package.
JoTurk
force-pushed
the
lint/test-helpers
branch
from
389246d to
8867eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use testify's assert package instead of the standard library's testing package.
Reference issue
pion/.goassets#222