Skip to content

Update lint rules, use testify/assert#447

Merged
RyanPotat merged 1 commit intomasterfrom
RyanPotat/lint/test-helpers
Mar 26, 2025
Merged

Update lint rules, use testify/assert#447
RyanPotat merged 1 commit intomasterfrom
RyanPotat/lint/test-helpers

Conversation

@RyanPotat
Copy link
Copy Markdown
Member

Description

Update lint rules to forbid the use of direct testing.T helpers. Removed a few //nolint:cyclop only by consequence of using assert. 🦆

pion/.goassets#222

Reference issue

N/A

@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch 2 times, most recently from 746ec30 to 37aae6e Compare March 26, 2025 08:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (03a668d) to head (437516a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          43       43           
  Lines        3083     3083           
=======================================
  Hits         2040     2040           
  Misses        876      876           
  Partials      167      167           
Flag Coverage Δ
go 66.16% <ø> (ø)
wasm 26.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch from 37aae6e to 437516a Compare March 26, 2025 09:07
Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Ryan

@RyanPotat RyanPotat merged commit 437516a into master Mar 26, 2025
15 checks passed
@RyanPotat RyanPotat deleted the RyanPotat/lint/test-helpers branch March 26, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants