Skip to content

Conversation

@JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Dec 31, 2025

Description

@jech reported a data race in read in here #3328

while it doesn't happen. a comment from @arjunshajitech in the discord made me notice a data race in ReadRTX. this is a test to prove it before I add a fix.

Taking about the latest issue opened by jech. #3328
I think that with simulcast enabled, there's a high possibility of it becoming racy.
After the lower layers start reading, the higher layers come in and mutate it in receiveForRid and
receiveForRtxInternal.
Correct me if i am wrong
@arjunshajitech

Edit: this includes the fix.

@JoeTurki JoeTurki force-pushed the fix-readRTX branch 2 times, most recently from 8390941 to 68ec19c Compare December 31, 2025 02:16
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.95%. Comparing base (d716c9b) to head (bdb7501).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   85.03%   84.95%   -0.09%     
==========================================
  Files          80       80              
  Lines        9491     9497       +6     
==========================================
- Hits         8071     8068       -3     
- Misses        999     1005       +6     
- Partials      421      424       +3     
Flag Coverage Δ
go 84.95% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoeTurki JoeTurki force-pushed the fix-readRTX branch 3 times, most recently from 6a5526f to 1702c3c Compare December 31, 2025 05:12
@JoeTurki JoeTurki changed the title Prove data race Fix data race in ReadRTX Dec 31, 2025
@JoeTurki JoeTurki changed the title Fix data race in ReadRTX Fix data race in RTX Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants