-
Notifications
You must be signed in to change notification settings - Fork 3
[Snyk] Security upgrade alpine from 3.16 to 3.18.12 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE316-BUSYBOX-6913410 - https://snyk.io/vuln/SNYK-ALPINE316-BUSYBOX-6913410 - https://snyk.io/vuln/SNYK-ALPINE316-MUSL-8720632 - https://snyk.io/vuln/SNYK-ALPINE316-MUSL-8720632
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
Changelist by BitoThis pull request implements the following key changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Agent Run #cd39b3
Actionable Suggestions - 1
-
hostplumber/Dockerfile - 1
- DPDK compatibility failure · Line 24-24
Review Details
-
Files reviewed - 1 · Commit Range:
433ca70..433ca70- hostplumber/Dockerfile
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| #FROM gcr.io/distroless/static:nonroot | ||
| FROM alpine:3.16 | ||
| FROM alpine:3.18.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Alpine upgrade from 3.16 to 3.18.12 introduces critical compatibility issues with the DPDK 21.11.3 build. Alpine 3.18.12 uses Linux kernel 6.1 LTS with updated musl libc 1.2.4, which causes compilation failures with DPDK 21.11.3 due to kernel header mismatches and DT_RELR linking issues. This will break the container build process. Update DPDK to version 22.11.3 or newer which has proper Alpine 3.18 compatibility, and consider updating Open vSwitch to 2.18.x for full compatibility with the newer toolchain.
Code suggestion
Check the AI-generated fix before applying
- pip3 install meson ninja && \
- wget http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-21.11.3.zip && \
- unzip dpdk-stable-21.11.3.zip
-WORKDIR dpdk-stable-21.11.3
+ pip3 install meson ninja && \
+ wget http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-22.11.3.zip && \
+ unzip dpdk-stable-22.11.3.zip
+WORKDIR dpdk-stable-22.11.3
Code Review Run #cd39b3
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
hostplumber/DockerfileWe recommend upgrading to
alpine:3.18.12, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-ALPINE316-BUSYBOX-6913410
SNYK-ALPINE316-BUSYBOX-6913410
SNYK-ALPINE316-MUSL-8720632
SNYK-ALPINE316-MUSL-8720632
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Bito
This pull request upgrades the Docker base image from alpine:3.16 to alpine:3.18.12 to address known security vulnerabilities and improve application stability. The update provides better protection through a more secure Alpine version, helping mitigate potential security risks in the container environment.