Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hostplumber/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go
# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
#FROM gcr.io/distroless/static:nonroot
FROM alpine:3.16
FROM alpine:3.18.12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DPDK compatibility failure

The Alpine upgrade from 3.16 to 3.18.12 introduces critical compatibility issues with the DPDK 21.11.3 build. Alpine 3.18.12 uses Linux kernel 6.1 LTS with updated musl libc 1.2.4, which causes compilation failures with DPDK 21.11.3 due to kernel header mismatches and DT_RELR linking issues. This will break the container build process. Update DPDK to version 22.11.3 or newer which has proper Alpine 3.18 compatibility, and consider updating Open vSwitch to 2.18.x for full compatibility with the newer toolchain.

Code suggestion
Check the AI-generated fix before applying
 -    pip3 install meson ninja && \
 -    wget http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-21.11.3.zip && \
 -    unzip dpdk-stable-21.11.3.zip 
 -WORKDIR dpdk-stable-21.11.3
 +    pip3 install meson ninja && \
 +    wget http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-22.11.3.zip && \
 +    unzip dpdk-stable-22.11.3.zip 
 +WORKDIR dpdk-stable-22.11.3

Code Review Run #cd39b3


Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

WORKDIR /

RUN apk update && apk upgrade
Expand Down