Fix check of prerelease versions #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erral
force-pushed
the
erral-volto-19-alpha
branch
from
3543efc to
f772c25
Compare
davisagli
requested changes
Apr 16, 2025
Member
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
This is not the right fix for #98. This function is used as a filter to calculate the default value for the use_prerelease_versions variable.
The actual problem is that the frontend_addon template is hardcoded to pass Yes for use_prerelease_versions when it uses the latest_volto filter here: https://github.com/plone/cookieplone-templates/blob/main/templates/add-ons/frontend/cookiecutter.json#L9
Member
|
@erral Here's the fix that works for me: plone/cookieplone-templates#217 |
Member
Author
|
I tested that it worked, but now it doesn't.... I suspect it was too early in the morning :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check function was only checking the environment var and not the user-entered preference.
I have kept the environment var override.
Fixes #98