Skip to content

Fix check of prerelease versions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erral wants to merge 2 commits into from
Closed

Fix check of prerelease versions #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
891711d
fix: fix check of prerelease versions
erral Apr 16, 2025
f772c25
changelog
erral Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cookieplone/filters/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,12 @@ def extract_host(hostname: str) -> str:


@simple_filter
def use_prerelease_versions(_: str) -> str:
def use_prerelease_versions(use_prerelease: str) -> str:
"""Should we use prerelease versions of packages."""
use_prerelease_versions = "USE_PRERELEASE" in os.environ
return "Yes" if use_prerelease_versions else "No"
use_prerelease_versions_check = "USE_PRERELEASE" in os.environ or parse_boolean(
use_prerelease
)
return "Yes" if use_prerelease_versions_check else "No"


@simple_filter
Expand Down
1 change: 1 addition & 0 deletions news/98.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix check of prerelease versions @erral
2 changes: 2 additions & 0 deletions tests/utils/test_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ def get_pypi_package_versions(*args, **kwargs):
["18.0.0-alpha.27", "17", None, True, True],
["18.0.0-alpha.27", "17", "18", True, True],
["18.0.0-alpha.27", "17", "17.99", True, False],
["19.0.0-alpha.0", "17", None, False, False],
["19.0.0-alpha.0", "17", None, True, True],
],
)
def test_is_valid_version(
Expand Down