Add rate limiter to helm agent fetches - #3893
Conversation
Soffi AI SummaryThis PR addresses scalability and reliability concerns in the Helm agent and deployment operator at large fleet scale, while also cleaning up a feature flag that is now ready for general availability. Rate limiting for Helm agent fetches ( Deployment operator service reconciliation tuning (
Chatbot feature flag removal ( Slack chat utility improvements ( Helm chart additions ( Commits
Updated: 2026-07-23 01:04 UTC |
Greptile SummaryThis PR adds rate limiting to Helm agent fetches. The main changes are:
Confidence Score: 5/5The changed flow looks mergeable after separating the Helm and Git rate limits.
lib/console/deployments/git/agent.ex
|
| Filename | Overview |
|---|---|
| lib/console/deployments/git/agent.ex | Exposes the rate-limit helper and raises its shared limit, which also weakens the existing Git-agent limit. |
| lib/console/deployments/helm/agent.ex | Applies the shared limiter to Helm fetch and digest calls after cache misses. |
Reviews (1): Last reviewed commit: "Add rate limiter to helm agent fetches" | Re-trigger Greptile
| @poll :timer.seconds(120) | ||
| @timeout :timer.seconds(10) | ||
| @limit 50 | ||
| @limit 100 |
There was a problem hiding this comment.
Raising this shared constant also doubles the existing Git tar and changes limits from 50 to 100 requests per second. Those paths receive no benefit from the new Helm limiter and can now place twice the prior load on each Git agent; Helm should use a separate limit so its tuning does not change existing Git protection.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
plural deploy this |
There was a problem hiding this comment.
Deploy PR created: https://github.com/pluralsh/plrl-up-demos/pull/2334
This updates the console deployment to sha-1c45cda for commit 1c45cda42d0d8fbb76fe89f3b086e202311d9253.
ec863fa to
517b4d6
Compare
29990fd to
361549e
Compare
Pretty sure these can get overwhelmed at large scale, and a simple rate limit should improve the load shedding here.
361549e to
c87c2e6
Compare
|
plural deploy this |
There was a problem hiding this comment.
Prepared for deploy: https://github.com/pluralsh/plrl-up-demos/pull/2335
902764c to
9ac1235
Compare
|
plural deploy this |
There was a problem hiding this comment.
Deploy PR created: https://github.com/pluralsh/plrl-up-demos/pull/2336
Image tag: sha-9ac1235
9ac1235 to
0858747
Compare
|
plural deploy this |
There was a problem hiding this comment.
Created deploy PR: https://github.com/pluralsh/plrl-up-demos/pull/2337
5c1647c to
f40d592
Compare
f40d592 to
9b888f8
Compare
|
plural deploy this |
There was a problem hiding this comment.
Created the deploy PR: https://github.com/pluralsh/plrl-up-demos/pull/2338 for image tag sha-9b888f8 from commit 9b888f890ecdb5b77336bf3159f7bec3b5bcf252.
f719b49 to
afa918a
Compare
|
plural deploy this |
There was a problem hiding this comment.
Deploy PR created for commit afa918a: https://github.com/pluralsh/plrl-up-demos/pull/2341
Pretty sure these can get overwhelmed at large scale, and a simple rate limit should improve the load shedding here.
Test Plan
Test environment: https://console.plrldemo.onplural.sh/cd/clusters/a1748282-ce8b-48ab-ae7e-326e74fce04e/services/f3f89a54-d1a7-4bc8-9152-daa07ede918d/components
Checklist
Plural Flow: console