fix(devtools): improve type inference for Devtools initializer by dbritto-dev · Pull Request #3511 · pmndrs/zustand

dbritto-dev · 2026-05-27T16:01:31Z

Related Bug Reports or Discussions

Related Discussion: #3510
Regression PR: #2875

Summary

Improves type inference for the devtools initializer in the Devtools middleware type.
Adds a dedicated type-level regression test for the #3510 scenario in tests/middlewareTypes.test.tsx to ensure create<MyState>()(devtools((set, get) => ...)) keeps set/get correctly inferred.

Check List

pnpm run fix for formatting and linting code and docs

vercel · 2026-05-27T16:01:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
zustand-demo	Ready	Preview, Comment	May 28, 2026 6:40am

codesandbox-ci · 2026-05-27T16:01:55Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

pkg-pr-new · 2026-05-27T16:02:10Z

demo
starter
```
npm i https://pkg.pr.new/zustand@3511
```

commit: 488862f

github-actions · 2026-05-27T16:02:10Z

Size Change: 0 B

Total Size: 13.1 kB

ℹ️ View Unchanged

Filename	Size
`dist/esm/index.mjs`	64 B
`dist/esm/middleware.mjs`	4.1 kB
`dist/esm/middleware/immer.mjs`	212 B
`dist/esm/react.mjs`	342 B
`dist/esm/react/shallow.mjs`	198 B
`dist/esm/shallow.mjs`	82 B
`dist/esm/traditional.mjs`	412 B
`dist/esm/vanilla.mjs`	405 B
`dist/esm/vanilla/shallow.mjs`	557 B
`dist/index.js`	244 B
`dist/middleware.js`	4.11 kB
`dist/middleware/immer.js`	231 B
`dist/react.js`	357 B
`dist/react/shallow.js`	213 B
`dist/shallow.js`	189 B
`dist/traditional.js`	426 B
`dist/vanilla.js`	418 B
`dist/vanilla/shallow.js`	568 B

_{compressed-size-action}

Copilot

Pull request overview

This PR updates the TypeScript typings for the devtools middleware to improve state type inference for the middleware initializer, addressing the inference problems reported in #3510.

Changes:

Refines the Devtools type signature to better infer the initializer’s state type (via a fallback inferred generic).
Adjusts the Devtools initializer/return StateCreator generics to reduce inference pitfalls in contextual typing scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dbritto-dev · 2026-05-27T17:29:38Z

@copilot let's fix the lint issue on tests/middlewareTypes.test.tsx

Copilot · 2026-05-27T17:32:49Z

@copilot let's fix the lint issue on tests/middlewareTypes.test.tsx

Addressed in commit d3cdcfe with a minimal lint fix in tests/middlewareTypes.test.tsx.

dai-shi

Thanks for the fix! The contribution is from @remziatay.

I'll merge it shortly.

dbritto-dev · 2026-05-28T00:14:20Z

@dai-shi actually, the PR was created 2 hours before @remziatay answer's but he came with the same solution haha

dai-shi · 2026-05-28T00:18:22Z

Oh, I didn't realize that. Sorry about it. Thanks for your work!

Bumps [zustand](https://github.com/pmndrs/zustand) from 5.0.12 to 5.0.14. Release notes *Sourced from [zustand's releases](https://github.com/pmndrs/zustand/releases).* > v5.0.14 > ------- > > This release fixes a type issue in devtools. > > What's Changed > -------------- > > * fix(devtools): improve type inference for Devtools initializer by [`@dbritto-dev`](https://github.com/dbritto-dev) in [pmndrs/zustand#3511](https://redirect.github.com/pmndrs/zustand/pull/3511) > > New Contributors > ---------------- > > * [`@TheSeydiCharyyev`](https://github.com/TheSeydiCharyyev) made their first contribution in [pmndrs/zustand#3487](https://redirect.github.com/pmndrs/zustand/pull/3487) > * [`@brofrong`](https://github.com/brofrong) made their first contribution in [pmndrs/zustand#3496](https://redirect.github.com/pmndrs/zustand/pull/3496) > * [`@hyun907`](https://github.com/hyun907) made their first contribution in [pmndrs/zustand#3506](https://redirect.github.com/pmndrs/zustand/pull/3506) > > **Full Changelog**: <pmndrs/zustand@v5.0.13...v5.0.14> > > v5.0.13 > ------- > > This release includes an improvement in the devtools middleware. > > What's Changed > -------------- > > * refactor(devtools): remove duplicate module augmentation by [`@mahmoodhamdi`](https://github.com/mahmoodhamdi) in [pmndrs/zustand#3443](https://redirect.github.com/pmndrs/zustand/pull/3443) > * fix(devtools): support Firefox/Safari stack format in findCallerName by [`@SBolsec`](https://github.com/SBolsec) in [pmndrs/zustand#3469](https://redirect.github.com/pmndrs/zustand/pull/3469) > > New Contributors > ---------------- > > * [`@mahmoodhamdi`](https://github.com/mahmoodhamdi) made their first contribution in [pmndrs/zustand#3443](https://redirect.github.com/pmndrs/zustand/pull/3443) > * [`@FelixEckl-vireq`](https://github.com/FelixEckl-vireq) made their first contribution in [pmndrs/zustand#3466](https://redirect.github.com/pmndrs/zustand/pull/3466) > * [`@KimHyeongRae0`](https://github.com/KimHyeongRae0) made their first contribution in [pmndrs/zustand#3471](https://redirect.github.com/pmndrs/zustand/pull/3471) > * [`@lstak`](https://github.com/lstak) made their first contribution in [pmndrs/zustand#3483](https://redirect.github.com/pmndrs/zustand/pull/3483) > * [`@AlexRixten`](https://github.com/AlexRixten) made their first contribution in [pmndrs/zustand#3474](https://redirect.github.com/pmndrs/zustand/pull/3474) > * [`@SBolsec`](https://github.com/SBolsec) made their first contribution in [pmndrs/zustand#3469](https://redirect.github.com/pmndrs/zustand/pull/3469) > > **Full Changelog**: <pmndrs/zustand@v5.0.12...v5.0.13> Commits * [`bfb2a9e`](pmndrs/zustand@bfb2a9e) 5.0.14 * [`62b2aff`](pmndrs/zustand@62b2aff) chore(deps): update dev dependencies ([#3513](https://redirect.github.com/pmndrs/zustand/issues/3513)) * [`ad77bd3`](pmndrs/zustand@ad77bd3) fix(devtools): improve type inference for Devtools initializer ([#3511](https://redirect.github.com/pmndrs/zustand/issues/3511)) * [`8476d2c`](pmndrs/zustand@8476d2c) update pnpm etc ([#3512](https://redirect.github.com/pmndrs/zustand/issues/3512)) * [`d690ec2`](pmndrs/zustand@d690ec2) docs(combine): add object constraints to T and U in signature ([#3506](https://redirect.github.com/pmndrs/zustand/issues/3506)) * [`fd8c601`](pmndrs/zustand@fd8c601) docs(react): add Action constraint to redux middleware signature ([#3492](https://redirect.github.com/pmndrs/zustand/issues/3492)) * [`2ce8226`](pmndrs/zustand@2ce8226) docs(immer): fix setPerson updater type in usage examples ([#3502](https://redirect.github.com/pmndrs/zustand/issues/3502)) * [`038b938`](pmndrs/zustand@038b938) docs(updating-state): use curried create form with explicit state type ([#3503](https://redirect.github.com/pmndrs/zustand/issues/3503)) * [`60a91b4`](pmndrs/zustand@60a91b4) docs(devtools): add missing devtools import to troubleshooting example ([#3501](https://redirect.github.com/pmndrs/zustand/issues/3501)) * [`efad169`](pmndrs/zustand@efad169) Update FUNDING.json * Additional commits viewable in [compare view](pmndrs/zustand@v5.0.12...v5.0.14) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=zustand&package-manager=npm\_and\_yarn&previous-version=5.0.12&new-version=5.0.14)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

fix(devtools): improve type inference for Devtools initializer

89ca618

Copilot AI review requested due to automatic review settings May 27, 2026 16:01

Copilot started reviewing on behalf of dbritto-dev May 27, 2026 16:01 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread src/middleware/devtools.ts Outdated

Comment thread src/middleware/devtools.ts Outdated

fix(devtools): enhance type inference for Devtools initializer

b3e7b4f

vercel Bot deployed to Preview May 27, 2026 16:08 View deployment

Copilot started work on behalf of dbritto-dev May 27, 2026 16:18 View session

test(types): add devtools inference regression for #3510

c75c5f0

vercel Bot deployed to Preview May 27, 2026 16:22 View deployment

Copilot finished work on behalf of dbritto-dev May 27, 2026 16:23

Rename options parameter to devtoolsOptions

ec094e9

vercel Bot deployed to Preview May 27, 2026 17:27 View deployment

Copilot started work on behalf of dbritto-dev May 27, 2026 17:29 View session

test(types): fix lint in devtools #3510 regression case

8590875

vercel Bot deployed to Preview May 27, 2026 17:31 View deployment

test(types): simplify lint-safe ts-expect-error expression

d3cdcfe

vercel Bot deployed to Preview May 27, 2026 17:32 View deployment

Copilot finished work on behalf of dbritto-dev May 27, 2026 17:33

dai-shi approved these changes May 27, 2026

View reviewed changes

Merge branch 'main' into hotfix-devtools-type-inference

488862f

vercel Bot deployed to Preview May 28, 2026 06:40 View deployment

dai-shi added this to the v5.0.14 milestone May 28, 2026

dai-shi merged commit ad77bd3 into main May 28, 2026
32 checks passed

dai-shi deleted the hotfix-devtools-type-inference branch May 28, 2026 09:46

This was referenced Jun 3, 2026

chore(deps): bump zustand from 5.0.12 to 5.0.14 zextras/carbonio-shell-ui#827

Closed

chore(deps): weekly dependencies update 2026-06-03 zextras/carbonio-shell-ui#830

Merged

chore(deps): weekly dependencies update 2026-06-03 zextras/carbonio-search-ui#185

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(devtools): improve type inference for Devtools initializer#3511

fix(devtools): improve type inference for Devtools initializer#3511
dai-shi merged 7 commits into
mainfrom
hotfix-devtools-type-inference

dbritto-dev commented May 27, 2026 •

edited by dai-shi

Loading

Uh oh!

vercel Bot commented May 27, 2026 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented May 27, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

dbritto-dev commented May 27, 2026 •

edited

Loading

Uh oh!

Copilot AI commented May 27, 2026

Uh oh!

dai-shi left a comment

Uh oh!

dbritto-dev commented May 28, 2026

Uh oh!

dai-shi commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

dbritto-dev commented May 27, 2026 • edited by dai-shi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Bug Reports or Discussions

Summary

Check List

Uh oh!

vercel Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

dbritto-dev commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented May 27, 2026

Uh oh!

dai-shi left a comment

Choose a reason for hiding this comment

Uh oh!

dbritto-dev commented May 28, 2026

Uh oh!

dai-shi commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dbritto-dev commented May 27, 2026 •

edited by dai-shi

Loading

vercel Bot commented May 27, 2026 •

edited

Loading

codesandbox-ci Bot commented May 27, 2026 •

edited

Loading

pkg-pr-new Bot commented May 27, 2026 •

edited

Loading

github-actions Bot commented May 27, 2026 •

edited

Loading

dbritto-dev commented May 27, 2026 •

edited

Loading