Skip to content

fix(devtools): improve type inference for Devtools initializer #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dai-shi merged 7 commits into from
May 28, 2026
+23 −1
Merged

fix(devtools): improve type inference for Devtools initializer #3511

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
89ca618
fix(devtools): improve type inference for Devtools initializer
dbritto-dev May 27, 2026
b3e7b4f
fix(devtools): enhance type inference for Devtools initializer
dbritto-dev May 27, 2026
c75c5f0
test(types): add devtools inference regression for #3510
Copilot May 27, 2026
ec094e9
Rename options parameter to devtoolsOptions
dbritto-dev May 27, 2026
8590875
test(types): fix lint in devtools #3510 regression case
Copilot May 27, 2026
d3cdcfe
test(types): simplify lint-safe ts-expect-error expression
Copilot May 27, 2026
488862f
Merge branch 'main' into hotfix-devtools-type-inference
dai-shi May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/middleware/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,21 @@ type Devtools = <
T,
Mps extends [StoreMutatorIdentifier, unknown][] = [],
Mcs extends [StoreMutatorIdentifier, unknown][] = [],
U = T,
InferredT extends object = object,
>(
initializer: StateCreator<T, [...Mps, ['zustand/devtools', never]], Mcs, U>,
devtoolsOptions?: DevtoolsOptions,
) => StateCreator<T, Mps, [['zustand/devtools', never], ...Mcs]>
initializer: StateCreator<
[T] extends [never] ? InferredT : NoInfer<T>,
[...Mps, ['zustand/devtools', never]],
Mcs,
[T] extends [never] ? InferredT : NoInfer<T>
>,
Comment thread
dbritto-dev marked this conversation as resolved.
Outdated
options?: DevtoolsOptions,
) => StateCreator<
Comment thread
dbritto-dev marked this conversation as resolved.
Outdated
[T] extends [never] ? InferredT : T,
Mps,
[['zustand/devtools', never], ...Mcs],
[T] extends [never] ? InferredT : T
>

type DevtoolsImpl = <T>(
storeInitializer: StateCreator<T, [], []>,
Expand Down
Loading