-
Notifications
You must be signed in to change notification settings - Fork 754
Improved fuzzer #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: libpng16
Are you sure you want to change the base?
Improved fuzzer #680
Conversation
Thank you. Could you please squash all your draft changes into a single commit, and explain what the squashed commit does in the commit message, using the rest of our commit messages as a stylistic guideline, as well as this guideline: |
|
I don't think squashing commits is helpful, particularly not here. The changes are apparently atomic and address specific issues so they should be separate commits. So far as the commits are concerned I concur with @ctruta; "lets see" is not helpful. @ctruta's link is a proforma that is reasonable to follow but I don't; I've had too many people in my life telling me how to speak English :-) Bottom line, say what was changed in the title (approximately, summarise), say what the change was in the description and say why. Don't use // comments in 1.6 code, unless @ctruta wants to change the rules in 1.6 code (I favour -std=c11). We can't change the past in git without --force so, @ctruta, if it works and given that the whole PR only affects exactly one file that, so far as I know, is completely dysfunctional, why look a gift horse in the mouth? |
Improved fuzzer to target png_init_read_transformations()