Skip to content

Refactor spo tenant appcatalog add to use util instead of calling other command, Closes #5307#5357

Draft
nicodecleyre wants to merge 4 commits intopnp:mainfrom
nicodecleyre:Refactor-spo-tenant-appcatalog-add
Draft

Refactor spo tenant appcatalog add to use util instead of calling other command, Closes #5307#5357
nicodecleyre wants to merge 4 commits intopnp:mainfrom
nicodecleyre:Refactor-spo-tenant-appcatalog-add

Conversation

@nicodecleyre
Copy link
Contributor

Closes #5307

@Adam-it
Copy link
Member

Adam-it commented Jul 28, 2023

Thank @nicodecleyre for another PR 👍 We will review it ASAP 🕵️‍♂️
BTW please do remember to also take care of the already reviewed PRs left in draft awaiting your feedback 🙏

@plamber plamber self-requested a review August 6, 2023 15:37
@plamber plamber self-assigned this Aug 6, 2023
@Adam-it Adam-it assigned Adam-it and unassigned plamber Aug 20, 2023
@Adam-it
Copy link
Member

Adam-it commented Aug 20, 2023

@plamber I will be taking over this one to go over all refactor to util PRs

@nicodecleyre nicodecleyre force-pushed the Refactor-spo-tenant-appcatalog-add branch from 39ebdbf to 0dd8405 Compare September 6, 2023 21:05
@Adam-it Adam-it marked this pull request as draft September 17, 2023 22:30
@Adam-it
Copy link
Member

Adam-it commented Sep 17, 2023

setting to draft due to the following observations
I will provide more guidance how we should proceed with this PR in near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor spo tenant appcatalog add to use util instead of calling other command

4 participants