Skip to content

Refactor spo tenant appcatalog add to use util instead of calling other command, Closes #5307 #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicodecleyre wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Refactor spo tenant appcatalog add to use util instead of calling other command, Closes #5307 #5357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fe93f0
First commit
nicodecleyre Jul 28, 2023
f773afb
Fix
nicodecleyre Jul 28, 2023
3a67046
Fix
nicodecleyre Jul 28, 2023
0dd8405
rebase gone wrong
nicodecleyre Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cli/Cli.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import os from 'os';
import path from 'path';
import sinon from 'sinon';
import url from 'url';
import Command, { CommandError } from '../Command.js';
import Command, { CommandError, CommandErrorWithOutput } from '../Command.js';
import AnonymousCommand from '../m365/base/AnonymousCommand.js';
import cliCompletionUpdateCommand from '../m365/cli/commands/completion/completion-clink-update.js';
import { settingsNames } from '../settingsNames.js';
Expand Down Expand Up @@ -1275,14 +1275,14 @@ describe('Cli', () => {
});

it('correctly handles error when executing command with output', (done) => {
sinon.stub(mockCommand, 'commandAction').callsFake(() => { throw 'Error'; });
sinon.stub(mockCommand, 'commandAction').callsFake(() => { throw new CommandErrorWithOutput(new CommandError('Error')); });
Cli
.executeCommandWithOutput(mockCommand, { options: { _: [] } })
.then(_ => {
done('Command succeeded while expected fail');
}, e => {
try {
assert.strictEqual(e.error, 'Error');
assert.strictEqual(e.error.error.message, 'Error');
done();
}
catch (e) {
Expand Down
Loading