fix: avoid SyncUpForm preview crash on interaction#3902
Open
Seungwan98 wants to merge 1 commit intopointfreeco:mainfrom
Open
fix: avoid SyncUpForm preview crash on interaction#3902Seungwan98 wants to merge 1 commit intopointfreeco:mainfrom
Seungwan98 wants to merge 1 commit intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3823.
Summary
SyncUpFormViewunchanged for production usageSyncUpFormContents#PreviewuseSyncUpFormPreviewView, which intentionally omits.bind($store.focus, to: $focus)This is a preview-only mitigation for the crash reported in #3823. The issue report notes that interacting with the
SyncUpFormpreview crashes, and that removing.bind(...)prevents the crash. This change keeps the production code path intact while making the preview use the same form content without the crashing focus-binding path.Validation
lsp_diagnostics Examples/SyncUps/SyncUps/SyncUpForm.swift→ no diagnosticsxcodebuild -workspace ComposableArchitecture.xcworkspace -scheme ComposableArchitecture -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO build→ succeedsxcodebuild -workspace ComposableArchitecture.xcworkspace -scheme SyncUps -showdestinations