Skip to content

fix: avoid SyncUpForm preview crash on interaction #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seungwan98 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix: avoid SyncUpForm preview crash on interaction #3902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Examples/SyncUps/SyncUps/SyncUpForm.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,25 @@ struct SyncUpFormView: View {
@Bindable var store: StoreOf<SyncUpForm>
@FocusState var focus: SyncUpForm.State.Field?

var body: some View {
SyncUpFormContents(store: store, focus: $focus)
.bind($store.focus, to: $focus)
}
}

private struct SyncUpFormPreviewView: View {
@Bindable var store: StoreOf<SyncUpForm>
@FocusState var focus: SyncUpForm.State.Field?

var body: some View {
SyncUpFormContents(store: store, focus: $focus)
}
}

private struct SyncUpFormContents: View {
@Bindable var store: StoreOf<SyncUpForm>
@FocusState.Binding var focus: SyncUpForm.State.Field?

var body: some View {
Form {
Section {
Expand Down Expand Up @@ -96,7 +115,6 @@ struct SyncUpFormView: View {
Text("Attendees")
}
}
.bind($store.focus, to: $focus)
}
}

Expand Down Expand Up @@ -129,7 +147,7 @@ extension Duration {

#Preview {
NavigationStack {
SyncUpFormView(
SyncUpFormPreviewView(
store: Store(initialState: SyncUpForm.State(syncUp: .mock)) {
SyncUpForm()
}
Expand Down