Add flamegraph feature
#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
force-pushed
the
flamegraph
branch
2 times, most recently
from
70c5788 to
277713f
Compare
erikgrinaker
force-pushed
the
flamegraph
branch
from
277713f to
716e3c3
Compare
umanwizard
approved these changes
Mar 3, 2025
|
TFTR! Would you mind cutting a new release sometime soon? |
|
Just published v0.7.0. BTW, we have a channel #rust-jemalloc-pprof on the Polar Signals discord server (https://discord.gg/knw3u5X9bs). It would be good to join if you plan to make more contributions or have any questions/issues that you want to discuss. |
|
Thanks! I don't have any further changes planned right now, but I'll stop by the Discord when I do. |
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Mar 4, 2025
## Problem The code to generate symbolized pprof heap profiles and flamegraph SVGs has been upstreamed to the `jemalloc_pprof` crate: * polarsignals/rust-jemalloc-pprof#22 * polarsignals/rust-jemalloc-pprof#23 ## Summary of changes Use `jemalloc_pprof` to generate symbolized pprof heap profiles and flamegraph SVGs. This reintroduces a bunch of internal jemalloc stack frames that we'd previously strip, e.g. each stack now always ends with `prof_backtrace_impl` (where jemalloc takes a stack trace for heap profiling), but that seems ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
flamegraphfeature, which can generate interactive flamegraph SVGs using theinfernocrate.It adds a new method
dump_flamegraph(), as well asdump_flamegraph_with_options()which takes aFlamegraphOptions(a re-export ofinferno::flamegraph::Options). This works similarly to thepprof-rsCPU profiler.It implies the
symbolizefeature from #22 which enables online profile symbolization.Example flamegraph: profile.svg.gz (download and open since GitHub breaks the interactive SVG)