Multi-target based on Roslyn version #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bash
force-pushed
the
roslyn-multi-targeting
branch
from
bb56ccb to
56b96eb
Compare
FreeApophis
approved these changes
Feb 3, 2025
|
It's hard to believe the support is this bad. Maybe reference the documentation you used to do this. |
Documentation? All the official documentation are a bunch of issues / PRs and the config used in dotnet/runtime 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays some groundwork for #828:
Since list patterns are a C# 11 feature, we'd have to update
Microsoft.CodeAnalysis.*which breaks compatibility with older .NET SDKs / Visual Studio versions.The solution for this is multi-targeting based on the Roslyn version (which unfortunately is not as convenient to do as multi-targeting based on the target framework and so requires some manual work).
That's what this PR does. I also added some docs on this in
Funcky.Analyzers/readme.md.