feat: add option helpers for comparison and assertion checks #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WithComparison and WithAsserts option helpers to allow programmatic configuration of checkComparison and checkAsserts flags. This enables fine-grained control over which error linting rules are applied when using the analyzer as a library. - Add WithComparison(bool) option helper for comparison checking - Add WithAsserts(bool) option helper for assertion checking - Add corresponding test cases and test data - All tests pass Signed-off-by: Kemal Akkoyun <[email protected]>
|
Thanks! |
github-merge-queue bot
pushed a commit
to DataDog/orchestrion
that referenced
this pull request
Sep 11, 2025
- Add new 'orchestrion lint' command - Use multichecker framework to run static analysis checks - Include custom help formatting to maintain Orchestrion CLI consistency - Add go-errorlint as the first linter - Enable comparison and asserts checks by default for error handling validation Needs polyfloyd/go-errorlint#107 before merging. Signed-off-by: Kemal Akkoyun <[email protected]> --------- Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: dd-k9-library-go[bot] <214463715+dd-k9-library-go[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to DataDog/orchestrion
that referenced
this pull request
Sep 11, 2025
- Add new 'orchestrion lint' command - Use multichecker framework to run static analysis checks - Include custom help formatting to maintain Orchestrion CLI consistency - Add go-errorlint as the first linter - Enable comparison and asserts checks by default for error handling validation Needs polyfloyd/go-errorlint#107 before merging. Signed-off-by: Kemal Akkoyun <[email protected]> --------- Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: dd-k9-library-go[bot] <214463715+dd-k9-library-go[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WithComparison and WithAsserts option helpers to allow programmatic
configuration of checkComparison and checkAsserts flags. This enables
fine-grained control over which error linting rules are applied when
using the analyzer as a library.
Signed-off-by: Kemal Akkoyun [email protected]