Merged
Conversation
ponylang-main
added
the
discuss during sync
SeanTAllen
force-pushed
the
lint-pony-doc-and-pony-lsp
branch
from
1a13f3b to
604616e
Compare
pony-lint was already linting its own source in CI. This extends that to pony-doc and pony-lsp so all three tools are held to the same standard. Adds lint-pony-doc and lint-pony-lsp Makefile targets and wires them into pr-tools.yml and ponyc-tier3.yml. Fixes all lint violations in both tools: file renames to match principal types, line-length wrapping, docstring formatting, blank-line spacing, call-argument formatting, exhaustive-match annotations, hard-tab removal, and public docstrings. Test fixtures in pony-lsp/test/error_workspace/ are excluded via .ignore since they contain intentional compile errors.
SeanTAllen
force-pushed
the
lint-pony-doc-and-pony-lsp
branch
from
604616e to
db8086a
Compare
orien
approved these changes
Apr 2, 2026
ponylang-main
removed
the
discuss during sync
SeanTAllen
added a commit
that referenced
this pull request
Apr 4, 2026
_MaxLineVisitor only checked node.line() for AST nodes, which reports only the start line of string literals. For multi-line docstrings, this meant blank lines inside the docstring body were miscounted as blank lines between members. The fix uses end_pos() to get the actual end line for multi-line TK_STRING nodes, scoped to strings whose token_value contains a newline (single-line and empty strings skip end_pos() due to a pre-existing parsing bug in that method for short strings). Also restores multi-paragraph docstrings in pony-lsp that were collapsed in #5098 as a workaround for this bug. Closes #5099
SeanTAllen
added a commit
that referenced
this pull request
Apr 4, 2026
…gs (#5109) _MaxLineVisitor only checked node.line() for AST nodes, which reports only the start line of string literals. For multi-line docstrings, this meant blank lines inside the docstring body were miscounted as blank lines between members. The fix uses end_pos() to get the actual end line for multi-line TK_STRING nodes, scoped to strings whose token_value contains a newline (single-line and empty strings skip end_pos() due to a pre-existing parsing bug in that method for short strings). Also restores multi-paragraph docstrings in pony-lsp that were collapsed in #5098 as a workaround for this bug. Closes #5099
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends pony-lint CI coverage to pony-doc and pony-lsp, so all three tools are held to the same linting standard.
lint-pony-docandlint-pony-lspMakefile targetspr-tools.yml(Linux only — linting is platform-independent)lint-pony-lintfromponyc-tier3.ymlPonyLspVersiontoVersionto match the convention used by pony-doc and pony-lintpony-lsp/test/error_workspace/from linting via.ignoresince those files contain intentional compile errors for LSP diagnostic testing