Conversation
Adds field declarations and usages to the class test, parameter declarations and usages to the function test, and empty-result checks for docstrings and blank lines. Extends _HoverWorkspaceServer to handle empty expected arrays as assertions that no hover result is returned.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The hover integration tests cover top-level entity declarations but do not exercise field declarations, field usages, function parameter declarations, parameter usages, or positions where hover should return nothing.
Changes
let,var,embedfields)_HoverWorkspaceServerto treat an empty expected array as "assert no hover result returned"Implements: #5106 (comment)