Add ConnectionFailedTimeout to ConnectionFailureReason#177
Merged
SeanTAllen merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
SeanTAllen
added
the
changelog - changed
ponylang-main
added
the
discuss during sync
SeanTAllen
changed the title
Lori 0.12.0 adds ConnectionFailedTimeout to its ConnectionFailureReason type. We pass the new variant through to our own union so users can match on it when connection timeouts are in use. The upgrade also renames expect() to buffer_until() with new types (Expect → BufferSize, None → Streaming).
SeanTAllen
force-pushed
the
upgrade-lori-0.12.0
branch
from
d3837d7 to
479fbb8
Compare
ponylang-main
removed
the
discuss during sync
Merged
SeanTAllen
added a commit
that referenced
this pull request
Mar 22, 2026
Thread lori's `ConnectionTimeout` through `ServerConnectInfo` to `Session` so users can bound the TCP connection phase. Without this, connections to unreachable hosts hang until the OS-level TCP timeout. `ServerConnectInfo` gains an optional `connection_timeout` parameter (default `None`). When set, lori fires `ConnectionFailedTimeout` if TCP doesn't connect in time — the existing failure mapping (from PR #177) delivers it to `pg_session_connection_failed`. `_CancelSender` does not use the connection timeout — cancel connections are fire-and-forget with no user callback, so a timeout would have no observable effect. Design: #72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades lori from 0.11.0 to 0.12.0 and fixes a stale ssl version reference in CLAUDE.md (2.0.0 → 2.0.1, left behind by #176).
Lori 0.12.0 renames
expect()tobuffer_until()(withExpect→BufferSize,None→Streaming,MakeExpect→MakeBufferSize) and addsConnectionFailedTimeouttoConnectionFailureReason. We pass the new variant through to our ownConnectionFailureReasonunion so users can match on it.