app-list: size-aware themed lookup; CRX-aware PWA fallback (cache + theme/maskable-aware); warn-only diagnostics#1123
Open
stephanbuys wants to merge 4 commits intopop-os:masterfrom
Conversation
mmstick
reviewed
Oct 29, 2025
mmstick
reviewed
Oct 29, 2025
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Oct 29, 2025
mmstick
reviewed
Oct 29, 2025
mmstick
reviewed
Oct 29, 2025
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Oct 29, 2025
…eam patch entries (PR pop-os#1123)
stephanbuys
force-pushed
the
feat/dock-pwa-icon-resolution-2025-10-29
branch
from
c4daee7 to
bd55d60
Compare
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Nov 20, 2025
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Nov 20, 2025
…eam patch entries (PR pop-os#1123)
mmstick
requested changes
Nov 24, 2025
cosmic-app-list/src/app.rs
Outdated
| // Helper: search common hicolor paths for a PNG named `<name>.png`, preferring larger sizes. | ||
| static ICON_FALLBACK_CACHE: OnceLock<Mutex<HashMap<(String, bool, u16), PathBuf>>> = OnceLock::new(); | ||
|
|
||
| fn find_hicolor_png(name: &str, requested_px: u16, prefer_dark: bool) -> Option<PathBuf> { |
Member
There was a problem hiding this comment.
All code related to icon lookup should be in https://github.com/pop-os/freedesktop-icons so that all applications that use this will get the same icons. This crate is already providing icon caching, so the duplicate layer of caching will increase memory usage for no benefit.
Author
There was a problem hiding this comment.
Switched fallback roots to BASE_PATHS in src/pwa.rs (see latest head). No hardcoded paths remain
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Nov 26, 2025
stephanbuys
added a commit
to stephanbuys/cosmic-applets
that referenced
this pull request
Nov 26, 2025
…eam patch entries (PR pop-os#1123)
stephanbuys
force-pushed
the
feat/dock-pwa-icon-resolution-2025-10-29
branch
from
bd55d60 to
5995a7f
Compare
…eam patch entries (PR pop-os#1123)
stephanbuys
force-pushed
the
feat/dock-pwa-icon-resolution-2025-10-29
branch
from
5995a7f to
ecffa38
Compare
Author
|
Removed an accidental Cargo.lock/hygiene commit so the diff is back to PR scope only. Functionality unchanged from prior review, just replayed cleanly on top of upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dock icons: crisp, correct-size themed lookup; SVG only for -symbolic.
PWA: If theme lookup fails, find best CRX export across hicolor roots; prefer dark/light by theme, prefer maskable, avoid monochrome, PNG>SVG; cache per (name, theme, size).
Logs: warn-only, include app_id/desktop_id/path inline + structured fields.
Perf: cold scan cached; hot path O(1).