refactor: get the outputs config from cosmic-comp-config#395
Draft
hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
Draft
refactor: get the outputs config from cosmic-comp-config#395hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
Conversation
mmstick
reviewed
Jan 21, 2026
mmstick
reviewed
Jan 21, 2026
hojjatabdollahi
force-pushed
the
hojjat/matching-config
branch
2 times, most recently
from
c9c583f to
25a9aa1
Compare
hojjatabdollahi
force-pushed
the
hojjat/matching-config
branch
from
25a9aa1 to
3c8a33f
Compare
Previously greeter had to get the outputs.ron config from cosmic-comp-config and then match it to the available displays. Now, it just sends the displays to the cosmic-comp-config and asks it to return the matching config. Moving the "match" logic to one place.
hojjatabdollahi
force-pushed
the
hojjat/matching-config
branch
from
3c8a33f to
97e95ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously greeter had to get the outputs.ron config from cosmic-comp-config and then match it to the available displays.
Now, it just sends the displays to the cosmic-comp-config and asks it to return the matching config. Moving the "match" logic to one place.
Currently this PR needs some cleanup (e.g. unnecessary freedesktop_entry_parser update). I'm just creating a draft to see if this approach is OK with the devs. This is part of this fix: pop-os/cosmic-comp#1988