Move plugin versions into properties section#5717
Conversation
|
@Konilo I believe so far dependabot was updating the dependencies. Will that work with the extracted versions (thinking about it: I guess because it used to work for Tycho)? And: what does the |
All hardcoded plugin versions in portfolio-app/pom.xml are now declared
in <properties> as ${<artifactId>.version} placeholders, matching the
existing ${tycho-version} pattern. Makes outdated plugins easier to
spot via `mvn versions:display-plugin-updates`.
The checkstyle dependency version inside maven-checkstyle-plugin is
intentionally left hardcoded since it is not a plugin version.
Issue: portfolio-performance#3244
23d68a1 to
dc78284
Compare
|
Dependabot: confirmed, and it already works in this repo. Dependabot bumps both styles:
One minor difference: the Dependabot PR titles for these plugins will read "Bump maven-resources-plugin.version from X to Y" instead of the full artifact coordinates, like the tycho PRs do now.
To be transparent, I took on this issue because it felt approachable for me as a new comer and was marked as |
All hardcoded plugin versions in portfolio-app/pom.xml are now declared
in <properties> as ${<artifactId>.version} placeholders, matching the
existing ${tycho-version} pattern. Makes outdated plugins easier to
spot via `mvn versions:display-plugin-updates`.
The checkstyle dependency version inside maven-checkstyle-plugin is
intentionally left hardcoded since it is not a plugin version.
Issue: #3244
Issue: #5717
|
Ah, thanks. Now I understand where you're getting from. Yes, I've merged the change. Nowadays, I'm relying on the dependabot updates (could be that the issue is from before that time). But the change improves readability and I have merged it. |
Hello!
This refactors
portfolio-app/pom.xmlso the remaining hardcoded plugin versions are declared in<properties>as${<artifactId>.version}placeholders, matching the existing${tycho-version}pattern. The goal, as discussed in the issue, is to make outdated plugins easier to spot viamvn versions:display-plugin-updates.Changes
<properties>block:maven-enforcer-plugin,maven-resources-plugin,maven-dependency-plugin,maven-jarsigner-plugin,maven-gpg-plugin,maven-checkstyle-plugin,sonar-maven-plugin,fix-info-plist-maven-plugin,exec-maven-plugin,jacoco-maven-plugin,protoc-jar-maven-plugin.${<artifactId>.version}, e.g.${maven-resources-plugin.version}.${tycho-version}is left as-is — already a property, shared by 8 Tycho plugins, so a short name made sense there. The new properties are 1:1 with their plugins, hence the more explicit<artifactId>.versionform.Not in scope
maven-checkstyle-plugin(13.4.2) is intentionally left hardcoded — it is a plugin dependency, not a plugin version, anddisplay-plugin-updatesdoes not check it.Verification
mvn -f portfolio-app/pom.xml clean verify -Plocal-dev→ BUILD SUCCESS, all 13 modules, 0 test failures.Closes #3244