Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: support lifting for L[BH]U instructions #2622

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

gballet
Copy link
Collaborator

@gballet gballet commented Apr 1, 2025

While running my program, I got an error saying that sbu wasn't supported after auipc.

There is some code tasked to "lift" whatever instruction comes after auipc in order to merge all the immediate computations into a single immediate. LBU is currently missing from it.

Copy link
Member

@lvella lvella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left a comment.

@lvella
Copy link
Member

lvella commented Apr 2, 2025

Please amend the title and description to L[BH]U instead of S[BHL]U.

@gballet gballet changed the title riscv: support lifting for S[BHL]U instructions riscv: support lifting for L[BH]U instructions Apr 2, 2025
@leonardoalt leonardoalt added this pull request to the merge queue Apr 3, 2025
Merged via the queue into powdr-labs:main with commit 74ff8cf Apr 3, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants