Update plotting code for ggplot2 deprecations#37
Open
foertsch wants to merge 1 commit intopowellgenomicslab:masterfrom
Open
Update plotting code for ggplot2 deprecations#37foertsch wants to merge 1 commit intopowellgenomicslab:masterfrom
foertsch wants to merge 1 commit intopowellgenomicslab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
This PR updates
plot_density_()to avoid current ggplot2 deprecation warnings.Summary
aes_string()with tidy-evalaes(...)using.dataelement_line(size = ...)withelement_line(linewidth = ...)Why
While checking
plot_density()on currentmaster, the plotting path worked correctly but emitted ggplot2 deprecation warnings for:aes_string()element_line(size = ...)This patch keeps behavior the same while making the plotting code compatible with current ggplot2 expectations.
Verification
Tested locally with:
and:
The direct call still returns a
ggplot, andtest-plot_density.Rnow passes without warnings.Note: I originally looked at issue #22, but current
masteralready appears to handle that Seurat-related failure. While verifying it, I noticed these ggplot2 deprecation warnings and prepared this small cleanup PR instead.