-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor connectivity break analysis to add connectivity loss impact of the contingencies #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vidaldid-rte
merged 29 commits into
main
from
connectivity-loss-in-connectivity-break-analysis
Apr 7, 2025
Merged
Refactor connectivity break analysis to add connectivity loss impact of the contingencies #1192
vidaldid-rte
merged 29 commits into
main
from
connectivity-loss-in-connectivity-break-analysis
Apr 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Hadrien-Godard
previously approved these changes
Mar 5, 2025
vidaldid-rte
reviewed
Mar 6, 2025
vidaldid-rte
reviewed
Mar 7, 2025
vidaldid-rte
reviewed
Mar 7, 2025
src/main/java/com/powsybl/openloadflow/dc/fastdc/ConnectivityBreakAnalysis.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Mar 7, 2025
src/main/java/com/powsybl/openloadflow/network/impl/PropagatedContingency.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Mar 7, 2025
src/main/java/com/powsybl/openloadflow/network/impl/PropagatedContingency.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Mar 7, 2025
src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promising refactoring.
I think their is however a bug with HVDC loss detection (see coments).
Some other comments.
Signed-off-by: p-arvy <[email protected]>
…connectivity-break-analysis
Signed-off-by: Hadrien <[email protected]>
…Results Signed-off-by: Hadrien <[email protected]>
…s both ends separated by a contingency Signed-off-by: Didier Vidal <[email protected]>
…he robot's judgement Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
…y-break-analysis' into connectivity-loss-in-connectivity-break-analysis
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
8 tasks
6 tasks
Signed-off-by: p-arvy <[email protected]>
…-break-analysis # Conflicts: # src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java # src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
|
vidaldid-rte
approved these changes
Apr 7, 2025
Hadrien-Godard
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No, but the development is based on the collaborative work of #1169 , aiming to improve the performance of the fast DC SA.
Note that this PR does not directly improve the performance of the fast DC SA but lays the groundwork for it while also improving code quality.
What kind of change does this PR introduce?
The connectivity loss calculation is directly integrated in the class
ConnectivityBreakAnalysis
, allowing to:WoodburyDcSecurityAnalysis
;Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
Connectivity results are redundantly obtained in the
WoodburyDcSecurityAnalysis
class. When theLfContingency
object is computed for each contingency (as the SA progresses), theContingencyConnectivityLossImpact
is calculated through a connectivity analysis.What is the new behavior (if this is a feature change)?
The connectivity results (
ContingencyConnectivityLossImpact
) are integrated in theConnectivityBreakAnalysis
.This approach allows the use of post-contingency connectivity to determine HVDC lines that end up without power, thus aligning the results of the fast DC SA with those of an equivalent load flow (where contingencies were applied manually).
Additionally, since
ConnectivityAnalysisResult
objects are used for both cases where a contingency either breaks connectivity or not, there is no longer a need to differentiate between these cases using separate method calls to compute the post-contingency state vector.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: