fix double slack distribution in SA DC #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
Merged
9 tasks
Hadrien-Godard
approved these changes
Mar 24, 2025
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
p-arvy
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Thanks for the bugfix @vidaldid-rte.
I confirm this corrects the TUs in PR #1192.
It also fixes some TUs added in PR #1153, adding the switching actions in fast DC SA. For some of them, there were differences between a classic DC SA and an equivalent DC LF.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
In DC the active power mismatch is computer on all bus whether they are enabled or disabled.
This leads to wrong computations in Security Analysis if the lost network contains unbalanced loads and generators.
Note that in general the slack distribution is a loss of time in DC security analysis because it was initially made extactly based on the contingency propagation. So the DC engine performs a useless iteration on all buses in SA.
What is the current behavior?
Slack distribution in DC security analysis (default mode) is long each time a unbalanced part of the network is lost.
What is the new behavior (if this is a feature change)?
Slack distribution in DC security analysis is correct.
Does this PR introduce a breaking change or deprecate an API?