Add missing log message for generators discarded from active power control because targetP < minP #1200
Conversation
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
|
SylvestreSakti
changed the title
SylvestreSakti
changed the title
| if (report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP > 0) { | ||
| LOGGER.warn("Network {}: {} generators have been discarded from active power control because of a targetP < minP", | ||
| lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP); | ||
| } |
There was a problem hiding this comment.
Now that this log is displayed it show an issue.
Generators with targetP=0 (or close to 0) appear in the category of stopped generators, but also in this category (if minP > 0).
The criteria that increments generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP should probably exclude stopped generators.
…P < minP Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
|
It was also the case with all the other checks, e.g. generators stopped but having targetP > maxTargetP were counted twice, generators stopped but having maxTargetP=minTargetP were counted twice, etc. It's now fixed |
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Add a missing log message
What is the current behavior?
Generators discarded from active power control for targetP < minP are counted but the count is never logged
What is the new behavior (if this is a feature change)?
The count is logged
Does this PR introduce a breaking change or deprecate an API?