Skip to content

Add missing log message for generators discarded from active power control because targetP < minP #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

Add missing log message for generators discarded from active power control because targetP < minP #1200

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0163a7d
Add missing log message
SylvestreSakti Mar 7, 2025
e13d41c
Remove stopped generators from the count of generators with minTarget…
SylvestreSakti Apr 11, 2025
fd67ddb
Merge branch 'main' into fix/missing_log_active_power_discarded_min_p
vidaldid-rte Apr 11, 2025
d0d9dab
Merge branch 'main' into fix/missing_log_active_power_discarded_min_p
jeandemanged Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,10 @@ private LfNetwork create(int numCC, int numSC, Network network, List<Bus> buses,
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of a targetP > maxP",
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseTargetPGreaterThanMaxP);
}
if (report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP > 0) {
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of a targetP < minP",
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this log is displayed it show an issue.
Generators with targetP=0 (or close to 0) appear in the category of stopped generators, but also in this category (if minP > 0).
The criteria that increments generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP should probably exclude stopped generators.

if (report.generatorsDiscardedFromActivePowerControlBecauseMaxPNotPlausible > 0) {
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of maxP not plausible",
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseMaxPNotPlausible);
Expand Down