-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ranking criteria
allow mapset host to indicate possession in a difficulty name
#12961
Open
Okorin
wants to merge
6
commits into
ppy:master
Choose a base branch
from
Okorin:rc-update-mapset-host-possession-rule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e9cf11
update Difficulty naming rules
Okorin fb64a92
fix formatting of newlines
Okorin 790923f
outdate-translations
Okorin e86411e
clarify that describing the collaborators is okay
Okorin 052f4c3
make it abundantly clear that `Collab` is optional
Okorin a55a8f7
Merge branch 'master' into rc-update-mapset-host-possession-rule
Okorin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that or
- **Difficulty names should not be misleading.** If it is unclear, a discussion should be held to come to a consensus on whether the difficulty name can be used or should be changed.
not sure which one was meant here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both suggestions are wrong, they are supposed to visually be on the same level as
Difficulty names should not be misleading
as you've guessedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to specify: the sentence was at the end and under the list because if none of the bulletpoints apply to your usecase and you're not sure, have a discussion before ranking the map was the idea, moving it up kinda makes it read worse to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "rank the same metadata twice" mean? it's very weird terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peppy ppy/osu-stable-issues#714 basically this usecase is when people are generally fine with including themselves as a difficulty owner in the format
Host's <Difficulty Level>
i.e.
Doormat's Easy
to avoid osu! thinking the difficulty is from the ranked setI didn't know a better way to word this while keeping it brief. Maybe I should elaborate in a footnote?