Prerequisite changes for song select v2 design work #32840
Merged
+89
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2025
peppy
reviewed
Apr 22, 2025
|
|
||
| namespace osu.Game.Screens.SelectV2 | ||
| { | ||
| internal partial class WedgeBackground : CompositeDrawable |
There was a problem hiding this comment.
added here but not really tested anywhere in this pr. i'll overlook this though as i already know what this is and what it does.
peppy
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General minor changes which are dependant by multiple PRs down the road:
SongSelectto be used by most/all coming PRs.WedgeBackgroundwhich is also used by most/all coming PRs.SongSelectComponentsTestSceneto use half width by default and allow adjusting anchor / default width, also add popover layer for components that show a popover.