Add song select beatmap leaderboard display

[frenzibyte]

• Depends on Prerequisite changes for song select v2 design work #32840
• Depends on Remove LeaderboardManager return value and simplify flow further #32913 (and application of refactors as per Add song select beatmap leaderboard display #32844 (comment))
• Split from Design implementation pass of Song Select v2 #32715

Preview:

CleanShot.2025-04-18.at.07.00.44.mp4

Notes:

• @peppy Seeing how BeatmapLeaderboard implements score fetching, I've attempted to follow suit and do the exact same to have full functionality support in de9146c. Feel free to revert / force-push this commit away if you still think it shouldn't be done here.

• If a score card goes partially off-screen, then resizing the width back and fourth doesn't work correctly. This is happening due to the parent of rankLabelStandalone getting masked away completely, and therefore not processing transforms to that component. I have no idea how to fix this one because the parent here is a cell container of GridContainer, somehow GridContainer.CellContainer needs to have IsMaskedAway never set to false.

  CleanShot.2025-04-18.at.07.04.04.mp4

• Total leaderboard scores count that was added in Include score count in beatmap scores response osu-web#12018 has not been implemented yet, as it requires minor changes to LeaderboardManager to carry the value across to consumers. To be done in a follow-up.

[peppy]

@peppy Seeing how BeatmapLeaderboard implements score fetching, I've attempted to follow suit and do the exact same to have full functionality support in de9146c. Feel free to revert / force-push this commit away if you still think it shouldn't be done here.

You copied a bug and missed a test, see #32816. Fixed via peppy@7a18a77.

[peppy]

Cases like 26f2703 make me very wary that you haven't run through all added tests on a visual level.

[frenzibyte]

Cases like 26f2703 make me very wary that you haven't run through all added tests on a visual level.

That's a test from master branch and doesn't look like one I need to carefully pay attention to, it displays non-sheared version while I'm working completely on sheared version. I'm not sure I have to be responsible for that.

I have tested each and every test case that matters to this PR chain and song select.

Leaderboard regression fix came in an unfortunate time as I've already prepared it for PR. Good find is all I can say.

[peppy]

@frenzibyte we have four mod tooltips now. the one in the beatmap score is only used, even though it could probably be applied to all mod switch types (and maybe all mods icons?):

what's the forward direction here?

---

Put another way: rather than adding the mod tooltip locally in a subclass of ModSwitchTiny, can it not be added to all mod switches?

[peppy]

A button called a switch, with no sounds attached.

[frenzibyte]

Has been removed as part of moving from tiny mod icons to the old full ones.

[peppy]

BeatmapLeaderboardScore is, nothing short of a pile of turd.

Yes, I get that it's not your original code, but it also feels like you've just turned a blind eye to it while also refactoring a good portion of the class.

As one example, it has a heap of local animations which are only activated in the TestSceneBeatmapLeaderboardScore (and look completely broken), but never seen outside of this. I'd have a hope that when you bring classes like this online – even in a design pass – you'd catch on to these things and amend them.

[frenzibyte]

@frenzibyte we have four mod tooltips now. the one in the beatmap score is only used, even though it could probably be applied to all mod switch types (and maybe all mods icons?):

what's the forward direction here?

Put another way: rather than adding the mod tooltip locally in a subclass of ModSwitchTiny, can it not be added to all mod switches?

I have responded to this in discord as there needs to be further discussion before settling on a direction and it tends to stray away from this PR (none of the changes in this PR play around with mod tooltips).

[peppy]

would it not make more sense to have the score popover show all mods with all details rather than having a local clickable expand thing just for mods for some arbitrary reason?

[peppy]

50% confidence