Add song select beatmap leaderboard display #32844

frenzibyte · 2025-04-18T11:17:33Z

Depends on Prerequisite changes for song select v2 design work #32840
Depends on Remove LeaderboardManager return value and simplify flow further #32913 (and application of refactors as per Add song select beatmap leaderboard display #32844 (comment))
Split from Design implementation pass of Song Select v2 #32715

Preview:

CleanShot.2025-04-18.at.07.00.44.mp4

Notes:

@peppy Seeing how BeatmapLeaderboard implements score fetching, I've attempted to follow suit and do the exact same to have full functionality support in de9146c. Feel free to revert / force-push this commit away if you still think it shouldn't be done here.
If a score card goes partially off-screen, then resizing the width back and fourth doesn't work correctly. This is happening due to the parent of rankLabelStandalone getting masked away completely, and therefore not processing transforms to that component. I have no idea how to fix this one because the parent here is a cell container of GridContainer, somehow GridContainer.CellContainer needs to have IsMaskedAway never set to false.

CleanShot.2025-04-18.at.07.04.04.mp4
Total leaderboard scores count that was added in Include score count in beatmap scores response osu-web#12018 has not been implemented yet, as it requires minor changes to LeaderboardManager to carry the value across to consumers. To be done in a follow-up.

Copied logic from `BeatmapLeaderboard`.

peppy · 2025-04-22T08:46:09Z

@peppy Seeing how BeatmapLeaderboard implements score fetching, I've attempted to follow suit and do the exact same to have full functionality support in de9146c. Feel free to revert / force-push this commit away if you still think it shouldn't be done here.

You copied a bug and missed a test, see #32816. Fixed via peppy@7a18a77.

We'll need to figure out what to do in multiplayer cases in the future, but the hope is that it can be done without further subclassing if possible.

peppy · 2025-04-22T09:05:15Z

Cases like 26f2703 make me very wary that you haven't run through all added tests on a visual level.

osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs

This removes a lot of movement, but honestly it didn't feel good in the first place. If anything I'll come back with a second-pass animation pass on this.

frenzibyte · 2025-04-22T12:20:51Z

Cases like 26f2703 make me very wary that you haven't run through all added tests on a visual level.

That's a test from master branch and doesn't look like one I need to carefully pay attention to, it displays non-sheared version while I'm working completely on sheared version. I'm not sure I have to be responsible for that.

I have tested each and every test case that matters to this PR chain and song select.

Leaderboard regression fix came in an unfortunate time as I've already prepared it for PR. Good find is all I can say.

Also handles some display edge cases where scores may overlap placeholder or do other weird things.

peppy · 2025-04-23T09:57:13Z

@frenzibyte we have four mod tooltips now. the one in the beatmap score is only used, even though it could probably be applied to all mod switch types (and maybe all mods icons?):

what's the forward direction here?

Put another way: rather than adding the mod tooltip locally in a subclass of ModSwitchTiny, can it not be added to all mod switches?

peppy · 2025-04-23T10:14:22Z

osu.Game/Screens/SelectV2/BeatmapLeaderboardScore.cs

        }

-        private sealed partial class MoreModSwitchTiny : CompositeDrawable
+        private sealed partial class MoreModSwitchTiny : CompositeDrawable, IHasPopover


A button called a switch, with no sounds attached.

peppy · 2025-04-23T10:16:51Z

BeatmapLeaderboardScore is, nothing short of a pile of turd.

Yes, I get that it's not your original code, but it also feels like you've just turned a blind eye to it while also refactoring a good portion of the class.

As one example, it has a heap of local animations which are only activated in the TestSceneBeatmapLeaderboardScore (and look completely broken), but never seen outside of this. I'd have a hope that when you bring classes like this online – even in a design pass – you'd catch on to these things and amend them.

…sore code

bdach · 2025-04-23T11:24:31Z

osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs

+                        {
+                            RelativeSizeAxes = Axes.X,
+                            AutoSizeAxes = Axes.Y,
+                            Margin = new MarginPadding { Top = 4f, Bottom = 180f },


Don't want to get too involved in the design side of things, but what is this bottom margin spec doing? I couldn't help but notice when checking the test scene that the margin makes it so that when you scroll all the way down there's a huge gap:

Seems much too weird for me to not say anything?

It's enough bottom bleed to allow the last card to show fully without being cut off from the left side.

Should probably be commented as such!

Has been resolved in bd58aac

frenzibyte · 2025-04-26T13:15:51Z

@frenzibyte we have four mod tooltips now. the one in the beatmap score is only used, even though it could probably be applied to all mod switch types (and maybe all mods icons?):

what's the forward direction here?

Put another way: rather than adding the mod tooltip locally in a subclass of ModSwitchTiny, can it not be added to all mod switches?

I have responded to this in discord as there needs to be further discussion before settling on a direction and it tends to stray away from this PR (none of the changes in this PR play around with mod tooltips).

frenzibyte added 2 commits April 18, 2025 05:31

Update beatmap leaderboard score design to match new metrics

c71f3de

Add new beatmap leaderboard score tooltip

60171f1

frenzibyte added area:song-select type:cosmetic labels Apr 18, 2025

frenzibyte requested a review from peppy April 18, 2025 11:17

pull-request-size bot added the size/XXL label Apr 18, 2025

frenzibyte force-pushed the song-select-v2-wedges-leaderboard branch 2 times, most recently from de9146c to 21d670d Compare April 18, 2025 12:51

frenzibyte added 2 commits April 18, 2025 08:54

Add beatmap leaderboard wedge

34e8943

Implement score fetch functionality

81d54a9

Copied logic from `BeatmapLeaderboard`.

frenzibyte force-pushed the song-select-v2-wedges-leaderboard branch from 21d670d to 81d54a9 Compare April 18, 2025 12:54

frenzibyte mentioned this pull request Apr 18, 2025

Bring all new song select components together #32854

Open

5 tasks

peppy added 2 commits April 22, 2025 17:34

Merge branch 'master' into song-select-v2-wedges-leaderboard

90f711d

Fix regression from copy waste

7a18a77

peppy added 2 commits April 22, 2025 18:01

Seal BeatmapLeaderboardScore for now

bec2d62

We'll need to figure out what to do in multiplayer cases in the future, but the hope is that it can be done without further subclassing if possible.

Fix non-sheared test showing sheared drawables

26f2703

bdach reviewed Apr 22, 2025

View reviewed changes

osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs Outdated Show resolved Hide resolved

peppy added 2 commits April 22, 2025 18:30

Make leaderbaord animation barely bareable

de82100

Don't animate on initial mode display

8bf95ca

This removes a lot of movement, but honestly it didn't feel good in the first place. If anything I'll come back with a second-pass animation pass on this.

This was referenced Apr 22, 2025

Remove LeaderboardManager return value and simplify flow further #32913

Merged

Song Select (v2) #32736

Open

peppy added 2 commits April 23, 2025 18:30

Merge branch 'master' into song-select-v2-wedges-leaderboard

99b44aa

Update fetch logic to match existing leaderboard

7c6a1f2

Also handles some display edge cases where scores may overlap placeholder or do other weird things.

Begin to fix eyesore code in BeatmapLeaderboardScore

698f9bd

peppy reviewed Apr 23, 2025

View reviewed changes

peppy and others added 2 commits April 23, 2025 19:31

Remove all animations from BeatmapLeaderboardScore and fix more eye…

d13c7e6

…sore code

Remove double binding

3b2e828

bdach reviewed Apr 23, 2025

View reviewed changes

peppy self-requested a review April 24, 2025 11:32

peppy added 4 commits April 24, 2025 21:14

Begin to fix BeatmapLeaderboardWedge code quality

bd58aac

Update 404ing cover image URLs

6cdbfe0

Fix user covers not loading if one corner is off-screen

18060d3

Merge branch 'master' into song-select-v2-wedges-leaderboard

f3ac93d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add song select beatmap leaderboard display #32844

Add song select beatmap leaderboard display #32844

frenzibyte commented Apr 18, 2025 •

edited by peppy

Loading

peppy commented Apr 22, 2025

peppy commented Apr 22, 2025

frenzibyte commented Apr 22, 2025 •

edited

Loading

peppy commented Apr 23, 2025 •

edited

Loading

peppy Apr 23, 2025

peppy commented Apr 23, 2025 •

edited

Loading

bdach Apr 23, 2025

frenzibyte Apr 23, 2025

peppy Apr 23, 2025

frenzibyte Apr 25, 2025

frenzibyte commented Apr 26, 2025

Add song select beatmap leaderboard display #32844

Are you sure you want to change the base?

Add song select beatmap leaderboard display #32844

Conversation

frenzibyte commented Apr 18, 2025 • edited by peppy Loading

peppy commented Apr 22, 2025

peppy commented Apr 22, 2025

frenzibyte commented Apr 22, 2025 • edited Loading

peppy commented Apr 23, 2025 • edited Loading

peppy Apr 23, 2025

Choose a reason for hiding this comment

peppy commented Apr 23, 2025 • edited Loading

bdach Apr 23, 2025

Choose a reason for hiding this comment

frenzibyte Apr 23, 2025

Choose a reason for hiding this comment

peppy Apr 23, 2025

Choose a reason for hiding this comment

frenzibyte Apr 25, 2025

Choose a reason for hiding this comment

frenzibyte commented Apr 26, 2025

frenzibyte commented Apr 18, 2025 •

edited by peppy

Loading

frenzibyte commented Apr 22, 2025 •

edited

Loading

peppy commented Apr 23, 2025 •

edited

Loading

peppy commented Apr 23, 2025 •

edited

Loading