Extract common logic from AddToPlaylistFooterButton#36829
Open
LiquidPL wants to merge 2 commits intoppy:masterfrom
Open
Extract common logic from AddToPlaylistFooterButton#36829LiquidPL wants to merge 2 commits intoppy:masterfrom
AddToPlaylistFooterButton#36829LiquidPL wants to merge 2 commits intoppy:masterfrom
Conversation
This commit rearranges the contents of `ShearedButtons` to be more independent of each other in regards to sizing. Thanks to that, the custom logic related to enabling autosizing is no longer necessary. With and height are no longer set via the constructor, and can be freely configured using the initializer syntax. Additionally, this allows the button to use relative sizing without having to resort to any hackery with `Size`.
Depends on ppy#36802 and ppy/osu-resources#408. This moves out the common layout from `AddToPlaylistFooterButton` to a separate `ShearedFooterButton`, that is intended to be used in other screens which I'm currently working on migrating them to the new footer. It also adds a new 'add' icon to be used on the playlists button. Pushing this ahead of time (without any other buttons using it yet) mostly to get the new icon on the add to playlist button. I've set the icon size to `20`. Could get it smaller, howvever I think it should be a *bit* taller than the button label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #36802 and ppy/osu-resources#408.
This moves out the common layout from
AddToPlaylistFooterButtontoa separate
ShearedFooterButton, that is intended to be usedin other screens which I'm currently working on migrating to the
new footer.
It also adds a new 'add' icon to be used on the playlists button.
Pushing this ahead of time (without any other buttons using it yet)
mostly to get the new icon on the add to playlist button.
I've set the icon size to
20. Could get it smaller, howveverI think it should be a bit taller than the button label.