Skip to content

don't use stacked position for playfield check

34a8f11
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Extend CheckOffscreenObjects to handle abnormal hitboject coordinates #36916

don't use stacked position for playfield check
34a8f11
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Mar 10, 2026 in 1s

30511 passed, 29 failed and 268 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 7606✅ 29❌ 67⚪ 1768s
TestResults-Linux-SingleThread.trx 7635✅ 67⚪ 1695s
TestResults-Windows-MultiThreaded.trx 7635✅ 67⚪ 3251s
TestResults-Windows-SingleThread.trx 7635✅ 67⚪ 2867s

❌ TestResults-Linux-MultiThreaded.trx

7702 tests were completed in 1768s with 7606 passed, 29 failed and 67 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 21✅ 29❌ 29s

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

✅ TestAttemptPlayBeatmapMissingFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestEnterGameplayWhileFilteringToNoSelection
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
❌ TestLastScoreNotNullAfterExitingPlayer
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestMainOverlaysClosesNotificationOverlay
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestMainOverlaysClosesSettingsOverlay
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestMenuMakesMusic
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestModSelectInput
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestModsResetOnEnteringMultiplayer
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestOffsetAdjustDuringGameplay
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestOffsetAdjustDuringPause
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestOpenModSelectOverlayUsingAction
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestOpenOptionsAndExitWithEscape
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestOverlayClosing
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestPresentBeatmapAfterDeletion
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestPushMatchSubScreenAndPressBackButtonImmediately
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestPushSongSelectAndPressBackButtonImmediately
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestQuickSkinEditorDoesntNukeSkin
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestRetryCountIncrements
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestRetryFromResults
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestRetryImmediatelyAfterCompletion
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestScrollSpeedAdjustDuringGameplay
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestSettingsViaHotkeyFromMainMenu
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestShowMedalAtResults
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestSongSelectBackActionHandling
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestSongSelectRandomRewindButton
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestSongSelectScrollHandling
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestToolbarHiddenByUser
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestTouchScreenDetectionAtSongSelect
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestTouchScreenDetectionInGame
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestVolumeMeterDragDoesNotDismissFocusedOverlay
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
❌ TestWaitForNextTrackInMenu
	System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
	  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing

✅ TestResults-Linux-SingleThread.trx

7702 tests were completed in 1695s with 7635 passed, 0 failed and 67 skipped.

✅ TestResults-Windows-MultiThreaded.trx

7702 tests were completed in 3251s with 7635 passed, 0 failed and 67 skipped.

✅ TestResults-Windows-SingleThread.trx

7702 tests were completed in 2867s with 7635 passed, 0 failed and 67 skipped.

Annotations

Check failure on line 217 in osu.Game/Online/Spectator/SpectatorClient.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestLastScoreNotNullAfterExitingPlayer

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
    ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
Raw output
System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task)
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--InvalidOperationException
   at osu.Game.Online.Spectator.SpectatorClient.<>c__DisplayClass47_0.<BeginPlaying>b__0() in /home/runner/work/osu/osu/osu.Game/Online/Spectator/SpectatorClient.cs:line 217
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass142_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Check failure on line 217 in osu.Game/Online/Spectator/SpectatorClient.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestMainOverlaysClosesNotificationOverlay

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
Error:
  System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
    ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
Raw output
System.AggregateException : One or more errors occurred. (Cannot invoke BeginPlaying when already playing)
  ----> System.InvalidOperationException : Cannot invoke BeginPlaying when already playing
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--InvalidOperationException
   at osu.Game.Online.Spectator.SpectatorClient.<>c__DisplayClass47_0.<BeginPlaying>b__0() in /home/runner/work/osu/osu/osu.Game/Online/Spectator/SpectatorClient.cs:line 217
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass142_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)