Skip to content

Rework user beatmap tag picker to match web #36989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiquidPL wants to merge 2 commits into
base: master
Choose a base branch
from
+92 −54

Fix missing corner radious on search box

04f72a4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Rework user beatmap tag picker to match web #36989

Fix missing corner radious on search box
04f72a4
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Mar 17, 2026 in 0s

27162 passed, 1 failed and 230 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 7631✅ 65⚪ 1904s
TestResults-Linux-SingleThread.trx 7631✅ 65⚪ 1644s
TestResults-Windows-MultiThreaded.trx 7631✅ 65⚪ 3297s
TestResults-Windows-SingleThread.trx 4269✅ 1❌ 35⚪ 993s

✅ TestResults-Linux-MultiThreaded.trx

7696 tests were completed in 1904s with 7631 passed, 0 failed and 65 skipped.

✅ TestResults-Linux-SingleThread.trx

7696 tests were completed in 1644s with 7631 passed, 0 failed and 65 skipped.

✅ TestResults-Windows-MultiThreaded.trx

7696 tests were completed in 3297s with 7631 passed, 0 failed and 65 skipped.

❌ TestResults-Windows-SingleThread.trx

4305 tests were completed in 993s with 4269 passed, 1 failed and 35 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.TestSceneLegacyBeatmapSkin 22✅ 1❌ 18s

❌ osu.Game.Rulesets.Osu.Tests.TestSceneLegacyBeatmapSkin

✅ TestBeatmapComboColours(False,False)
✅ TestBeatmapComboColours(False,True)
✅ TestBeatmapComboColours(True,False)
✅ TestBeatmapComboColours(True,True)
✅ TestBeatmapComboColoursOverride(False)
✅ TestBeatmapComboColoursOverride(True)
✅ TestBeatmapComboColoursOverrideWithDefaultColours(False)
✅ TestBeatmapComboColoursOverrideWithDefaultColours(True)
✅ TestBeatmapNoComboColours(False,False)
✅ TestBeatmapNoComboColours(False,True)
✅ TestBeatmapNoComboColours(True,False)
✅ TestBeatmapNoComboColours(True,True)
✅ TestBeatmapNoComboColoursSkinOverride(False,False)
✅ TestBeatmapNoComboColoursSkinOverride(False,True)
✅ TestBeatmapNoComboColoursSkinOverride(True,False)
✅ TestBeatmapNoComboColoursSkinOverride(True,True)
❌ TestComboOffsetWithBeatmapColours(False,False)
	"wait for objects to become alive" timed out
✅ TestComboOffsetWithBeatmapColours(False,True)
✅ TestComboOffsetWithBeatmapColours(True,False)
✅ TestComboOffsetWithBeatmapColours(True,True)
✅ TestComboOffsetWithIgnoredBeatmapColours(False)
✅ TestComboOffsetWithIgnoredBeatmapColours(True)
✅ TestConstructor

Annotations

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Rulesets.Osu.Tests.TestSceneLegacyBeatmapSkin ► TestComboOffsetWithBeatmapColours(False,False) 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "wait for objects to become alive" timed out
Raw output 
"wait for objects to become alive" timed out
   at osu.Game.Rulesets.Osu.Tests.TestSceneLegacyBeatmapSkin.assertCorrectObjectComboColours(String description, Color4[] expectedColours, Func`3 nextExpectedComboIndex) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\TestSceneLegacyBeatmapSkin.cs:line 115
   at osu.Game.Rulesets.Osu.Tests.TestSceneLegacyBeatmapSkin.TestComboOffsetWithBeatmapColours(Boolean userHasCustomColours, Boolean useBeatmapSkin) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\TestSceneLegacyBeatmapSkin.cs:line 97
   at InvokeStub_TestSceneLegacyBeatmapSkin.TestComboOffsetWithBeatmapColours(Object, Span`1)
View more details on GitHub Actions