Refactor leaderboard statistics component to use text flows#37069
Open
LiquidPL wants to merge 1 commit intoppy:masterfrom
Open
Refactor leaderboard statistics component to use text flows#37069LiquidPL wants to merge 1 commit intoppy:masterfrom
LiquidPL wants to merge 1 commit intoppy:masterfrom
Conversation
LiquidPL
commented
Mar 23, 2026
| { | ||
| t.Font = OsuFont.Style.Body; | ||
| t.Colour = perfect ? colours.Lime1 : Color4.White; | ||
| t.Padding = new MarginPadding { Left = direction == Direction.Horizontal ? 0 : 5 }; |
Contributor
Author
There was a problem hiding this comment.
I just realized this is going to cause every word in value to have padding if there's multiple words in it. I wonder if this is even likely to happen, given that in most cases what goes into value is going to be a single number.
Alternatively I could just insert a single space between name and value instead of messing around with padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done to avoid any baseline alignment issues that occur when the name/label are laid out horizontally, as mentioned in #37056.
Also extracts it to a separate component, to be reused on the playlists leaderboard.
Expanded layout on the playlists leaderboard POC:
Compact layout (I wonder if it'd look better if the lines were aligned to the right instead):
Regular beatmap leaderboard:
Supersedes #37056.