feat!: allow to run any script for clean/install/build - #126
Conversation
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
I realize this is a draft but please revert all formatting & other unrelated changes before opening up for review, they can be submitted separately if you think they're worthwhile.
|
@rschristian Will check again, seems the IDE does not know which to use prettier or editorconfig PS: reverted prettier changes in the action.yml |
|
@rschristian I left some notes, when you have time please take a look |
There was a problem hiding this comment.
The formatting changes were done by your editor formatting on save, the config sat in the repo root is pretty innocent.
PRs should ideally only contain relevant changes. Formatting discrepancies and dependency bumps should be entirely separate PRs.
Revert everything down to the very specific changes you're actually proposing here. This is unreviewable as-is unfortunately.
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
Thanks for taking a swing at landing this! I appreciate it.
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
I just created a v3 branch & switched your PR over to target it so that we can at least merge this in & you're not left rebasing as I figure out a timeline here.
At best, this can go out maybe at the end of January as I need to a) put in deprecation notices for folks missing scripts, giving them a nudge to add them before they become required, and b) wrangle up any other changes that should go along with a new major. At the same time, with the holidays coming up I have very limited free time so we'll see if/when I can do any of that.
Thanks for doing this & working with me to get those corrections in!
|
Great news! |
Uploading a build is part of the publish process, that'll only be done when/if a v3 release is cut. |
|
Hey @rschristian! Is there any timeline when v3 will be built? I see downstream repositories started using v3 branch, because Dependabot reported the update with no breaking changes. It seems that now if doing a v3 built, it my break the downstream CI jobs 🤔 |
Want to start using it? Happy to push up a build after work today.
Hm, another reason to avoid dependabot I guess. If users are blindly using the new version because dependabot told them to, any breakages are on them. Nothing we can really do about that. Using a branch instead of a proper release is quite a bad idea, if you're not intentional about it anyhow. If you landed changes that you want to use early then that's a different matter obviously 😅 |
|
Commiting the build changes in v3 without a release I think should be enough 🤔 |
* feat!: allow to run any script for clean/install/build * docs: change v2 to v3 * chore: revert action.yml prettier changes * docs: add important note that scripts need to exist in both branches * docs: fix configs in README * chore: update microbundle to support Optional chaining * feat: make install-script optional, some don't need it * chore: run build * chore: revert all unrelated changes * fix: add logs back * fix: add the required inputs in action workflow
|
Pushed a build for you: 261e5e2 |
|
Thanks! |
2 participants
Closes #119
Closes potentially also: