Remove fast-async - #1347
Conversation
| excludedPlugins: ['BabelEsmPlugin', 'InjectManifest'], | ||
| beforeStartExecution: (plugins, newConfig) => { | ||
| const babelPlugins = newConfig.plugins; | ||
| newConfig.plugins = babelPlugins.filter((plugin) => { |
There was a problem hiding this comment.
this makes sure 'fast-async' are not added, why remove this?
There was a problem hiding this comment.
I did a serach for fast-async in code and figured if I'm removing it as dependency any related code would be safe to remove also. Unless goal was to also prevent users from adding it via custom babelrc?
| ], | ||
| ], | ||
| plugins: [ | ||
| require.resolve('babel-plugin-transform-async-to-promises'), |
There was a problem hiding this comment.
in modern mode we don't need this. All modern browsers support async/await. Wouldn't adding this here add it for both modern and legacy mode?
There was a problem hiding this comment.
Hm, now the tests are failing again. I'll admit this task proved more complex than I thought so I would welcome some guidance around it.
|
One thing I'd like to consider before we jump to merging this: in the case where |
Due to the amount of code transpiled or is there more to it? My (very shallow) understanding is that Babel would adjust output based on browserslist config (either default or provided by the user) so if deeper browser support is needed (ie. no I'm also interested to learn how #1116 plays into this? |
|
@teodragovic Any chance you can take a look at those merge conflicts with the main branch and give this PR some fresh air? |
🦋 Changeset detectedLatest commit: b31fa58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 participants
What kind of change does this PR introduce?
Remove
fast-asyncfrom dependency list in favor of usingtransform-async-to-generatorFixes #1591
Did you add tests for your changes?
No
Summary
Going off this comment by @developit I jumped on it as a chance to get rid of moderate security vulnerability after
preact-cliinstall.Does this PR introduce a breaking change?
I don't think so?