Skip to content

Remove fast-async #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 11 commits into from
Oct 6, 2021
Merged

Remove fast-async #1347

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00b750c
Remove fast-async
teodragovic Jul 25, 2020
b29f98f
Add regenerator runtime
teodragovic Jul 25, 2020
be71852
Try using transform-runtime
teodragovic Jul 25, 2020
74e081e
Try transforming async to promise
teodragovic Jul 25, 2020
4e6a138
Revert to exclude transform-regenerator
teodragovic Aug 5, 2020
bdadd09
Merge branch 'master' into remove-fast-async
teodragovic Aug 5, 2020
8d49185
Remove transform-async-to-promises
teodragovic Aug 6, 2020
e8583d3
Merge branch 'master' into remove-fast-async
prateekbh Aug 6, 2020
a4253c0
Merge branch 'master' into remove-fast-async
teodragovic Sep 24, 2021
117fc68
Merge branch 'master' into remove-fast-async
ForsakenHarmony Sep 30, 2021
b31fa58
Create thick-clocks-bow.md
ForsakenHarmony Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/cli/lib/lib/babel-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = function (env, options = {}) {
targets: {
browsers: options.browsers,
},
exclude: ['transform-regenerator', 'transform-async-to-generator'],
exclude: ['transform-regenerator'],
},
],
],
Expand All @@ -23,7 +23,6 @@ module.exports = function (env, options = {}) {
require.resolve('@babel/plugin-proposal-object-rest-spread'),
isProd &&
require.resolve('babel-plugin-transform-react-remove-prop-types'),
[require.resolve('fast-async'), { spec: true }],
require.resolve('babel-plugin-macros'),
[
require.resolve('@babel/plugin-transform-react-jsx'),
Expand Down
8 changes: 2 additions & 6 deletions packages/cli/lib/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,8 @@ function getBabelEsmPlugin(config) {
: '[name].esm.js',
chunkFilename: '[name].chunk.[chunkhash:5].esm.js',
excludedPlugins: ['BabelEsmPlugin', 'InjectManifest'],
beforeStartExecution: (plugins, newConfig) => {
const babelPlugins = newConfig.plugins;
newConfig.plugins = babelPlugins.filter(plugin => {
return !(Array.isArray(plugin) && plugin[0].includes('fast-async'));
});
plugins.forEach(plugin => {
beforeStartExecution: (plugins) => {
plugins.forEach((plugin) => {
if (
plugin.constructor.name === 'DefinePlugin' &&
plugin.definitions
Expand Down
1 change: 0 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"ejs-loader": "^0.5.0",
"envinfo": "^7.8.1",
"esm": "^3.2.25",
"fast-async": "^6.3.7",
"file-loader": "^6.2.0",
"fork-ts-checker-webpack-plugin": "^4.0.4",
"get-port": "^5.0.0",
Expand Down