fix: Rest param segment not matching optional segment#63
Closed
rschristian wants to merge 2 commits intomainfrom
Closed
fix: Rest param segment not matching optional segment#63rschristian wants to merge 2 commits intomainfrom
rschristian wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
Actually, this now rings a bell and might be intentional.. Need to reread my notes |
Member
Author
|
On nope, we've already been over this with #27. Working as intended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically we split the URL into segments, iterating over each segment to test if it matches a given param. Despite
*meaning "0 or more", we were checking that it actually existed as a segment in the provided URL.Imagine the URL
/movies& the path/movies/*:movies) has a value & matches the pattern&& valcheck failsA few people have reported issues with the nesting routers over the past few months but no one has been able to provide a reproduction; I'm guessing this is the root behind all of them. Cheers to @sbesh91 for finding this.