Skip to content

fix: Rest param segment not matching optional segment #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rschristian wants to merge 2 commits into from
Closed

fix: Rest param segment not matching optional segment #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a559b63
fix: Wildcard path segments not working as intended
rschristian Feb 10, 2025
e6bd32a
chore: Simplify diff
rschristian Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const exec = (url, route, matches = {}) => {
// segment match:
if (!m && param == val) continue;
// /foo/* match
if (!m && val && flag == '*') {
if (!m && flag == '*') {
matches.rest = '/' + url.slice(i).map(decodeURIComponent).join('/');
break;
}
Expand Down
3 changes: 3 additions & 0 deletions test/node/router-match.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ test('Param rest segment', () => {
const accurateResult = execPath('/user/foo', '/user/*');
assert.equal(accurateResult, { path: '/user/foo', params: {}, query: {}, rest: '/foo' });

const accurateResult2 = execPath('/user', '/user/*');
assert.equal(accurateResult2, { path: '/user', params: {}, query: {}, rest: '/' });

const inaccurateResult = execPath('/', '/user/:id/*');
assert.equal(inaccurateResult, undefined);
});
Expand Down