TRUSTX Bid Adapter: initial release #14218
Conversation
Remove trustx alias from grid adapter as a new standalone trustx adapter is being introduced. Keeping the alias would cause conflicts when both adapters are present in the same Prebid.js build.
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
modules/trustxBidAdapter.js
Outdated
| keywords: userKeywords.split(','), | ||
| } | ||
| ]; | ||
| // Add ortb2 keywords to pageKeywords if present |
There was a problem hiding this comment.
hi, we consdier this commit to be poor conduct and a malicious commit. Please revert it
| code: BIDDER_CODE, | ||
| gvlid: GVLID, | ||
| aliases: ['playwire', 'adlivetech', 'gridNM', { code: 'trustx', skipPbsAliasing: true }], | ||
| aliases: ['playwire', 'adlivetech', 'gridNM'], |
There was a problem hiding this comment.
given that your new file seems largely identical to the grid adapter, could you explain why you are proposing this change?
There was a problem hiding this comment.
@patmmccann TRUSTX is moving away from Criteo’s Grid to its own ad server, which requires a dedicated standalone adapter.
Any similarity to the existing Grid adapter is intentional, ensuring a smooth transition for current TRUSTX publishers while preserving performance. The new adapter remains fully compatible with existing Grid parameters—uid/secid, bidFloor, keywords, and others—so publishers can migrate without any code changes. This preserves seamless adoption and minimizes integration friction
The PR also removes the trustx alias from the Grid adapter to prevent conflicts. The new standalone adapter becomes the official and only integration point for TRUSTX.
There was a problem hiding this comment.
do you own the endpoint? Are you really building out the deletion request support and the first party id that is redundant with shardid. They are some extremely unique things grid is doing that you are copying here that makes it seem like you are still grid
- Remove localStorage user ID handling (using Prebid User ID modules) - Remove onDataDeletionRequest (not needed) - Remove custom keywords processing - Remove unused utility imports - Update doc overview
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
3 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR introduces a TRUSTX bid adapter for Prebid.js.
Maintainer: [email protected]
Test parameters for validating bids:
Other information
In this PR, we also added a change to remove the
trustxalias from the gridBidAdapter, since a new standalone TRUSTX adapter is being introduced. Keeping the alias would cause conflicts when both adapters are included in the same Prebid.js build.Docs PR: prebid/prebid.github.io#6355