Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions modules/gridBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ const LOG_ERROR_MESS = {
};

const ALIAS_CONFIG = {
'trustx': {
endpoint: 'https://grid.bidswitch.net/hbjson?sp=trustx',
syncurl: 'https://x.bidswitch.net/sync?ssp=themediagrid',
bidResponseExternal: {
netRevenue: false
}
},
'gridNM': {
defaultParams: {
multiRequest: true
Expand All @@ -66,7 +59,7 @@ let hasSynced = false;
export const spec = {
code: BIDDER_CODE,
gvlid: GVLID,
aliases: ['playwire', 'adlivetech', 'gridNM', { code: 'trustx', skipPbsAliasing: true }],
aliases: ['playwire', 'adlivetech', 'gridNM'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that your new file seems largely identical to the grid adapter, could you explain why you are proposing this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann TRUSTX is moving away from Criteo’s Grid to its own ad server, which requires a dedicated standalone adapter.
Any similarity to the existing Grid adapter is intentional, ensuring a smooth transition for current TRUSTX publishers while preserving performance. The new adapter remains fully compatible with existing Grid parameters—uid/secid, bidFloor, keywords, and others—so publishers can migrate without any code changes. This preserves seamless adoption and minimizes integration friction
The PR also removes the trustx alias from the Grid adapter to prevent conflicts. The new standalone adapter becomes the official and only integration point for TRUSTX.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you own the endpoint? Are you really building out the deletion request support and the first party id that is redundant with shardid. They are some extremely unique things grid is doing that you are copying here that makes it seem like you are still grid

supportedMediaTypes: [ BANNER, VIDEO ],
/**
* Determines whether or not the given bid request is valid.
Expand Down
Loading
Loading