-
Notifications
You must be signed in to change notification settings - Fork 2.3k
TRUSTX Bid Adapter: initial release #14218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
867fc1f
TRUSTX Bidder Adapter
trustXops 6e0dc89
Remove trustx alias in favor of standalone adapter
trustXops b2fbe2d
Update default ttl and usync delete url
trustXops 8a04538
Align docs/tests with param type
trustXops 1ee7765
Refactor duplicate code patterns
trustXops b224963
refactor & simplify adapter
trustXops 8e0c80c
Fix linter error
trustXops cb60a03
Merge branch 'master' into trustx-bidder-adapter
patmmccann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that your new file seems largely identical to the grid adapter, could you explain why you are proposing this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann TRUSTX is moving away from Criteo’s Grid to its own ad server, which requires a dedicated standalone adapter.
Any similarity to the existing Grid adapter is intentional, ensuring a smooth transition for current TRUSTX publishers while preserving performance. The new adapter remains fully compatible with existing Grid parameters—uid/secid, bidFloor, keywords, and others—so publishers can migrate without any code changes. This preserves seamless adoption and minimizes integration friction
The PR also removes the trustx alias from the Grid adapter to prevent conflicts. The new standalone adapter becomes the official and only integration point for TRUSTX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you own the endpoint? Are you really building out the deletion request support and the first party id that is redundant with shardid. They are some extremely unique things grid is doing that you are copying here that makes it seem like you are still grid